From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795099204; b=fCi9YtUmmckP5RwEWc+en7yeC/Dd2GAgfIArTjOjEXwnAxwKY8TBLOpaYCEJkHLd6BRv XHyuAN7kqXRs5XA0AXRM2eDrohT6clTMWfRTG6v5We1gRH+AWskugZtibCMmcNlMGEjeD hH6PEqbOzbb9mZrRSKJ6pkAXFUyOfZNqPgox1PvnOxJvaemyUZTNJPb7cwLSv6i7jrQH2 OiibhfQ2eHfZ6zX7oHP+W4OvyakiVrVTmqZD1bgKQQWlDBxDmfiv+uBITBAkBuw3V5i33 kci8/M2E85TOppQJ0nspNxij+JuWYf5d3y5p/oADLcjZjSSQxGm9JHKRdDykkNze/hw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795099204; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: Reply-To:MIME-Version:Lines:X-Developer-Signature:X-Developer-Key: Content-Transfer-Encoding; bh=6lGe0bSTNsBjnlleqDhzGwHz22BS7/TPu5kr0EnMrjM=; b=XTs3CfvXwNGNfy4WQrSpDY8fH3U67TYnLMvzC/6TdoWp+p05XutQrWGSij/whhxZ9x4G HLupFKXAfmRW0JtWEtKRmaJwcHB/4Fr/pbuDP0m9jUDufIN9mF7tTcQk9k2iCI4JzyQLl Wjy7m1lVhsxnwHi3hc/cwUkX1TwWq8/TxT67E/wvFE5EB946hVT1OII/LsgvjVHD3yVy/ NRhzoUw3+8H2me49I/4nPiJcGEeUEB4LhyU4y5jC1QaI9WkmCabAj5C/uAGj0e0bbTg3d /sOVpMVwgBB5AC+HuP7hcaWNpBbWzOO6co/ZlVGY74RGNbJIighYg4DS1lU2UfOO4oQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=iPsJ5SMW; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3FA1606A320 for ; Thu, 19 Nov 2026 14:40:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=iPsJ5SMW Received: by smtp.kernel.org (Postfix) with ESMTPSA id 178741F000C4; Thu, 19 Nov 2026 14:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795099204; bh=6lGe0bSTNsBjnlleqDhzGwHz22BS7/TPu5kr0EnMrjM=; h=From:To:Cc:Subject:Date:Reply-To; b=iPsJ5SMW0LjtX4MheGZ465Cw66MXF+Ur/7hxIj5dnnf6nrJ2gRzTvf8egm1VxzlZf Yx0S3tSxkIIL7xRjxyuv8z9bWLW4VN53QH7JvzLwtob7E055RcmLOCzcRCRgbHRjHW 2ACWWypjcy5/vYNf7ZiHveNsYBvaSwEU9Do7wTNI= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2026-99366: nfsd: don't modify a session slot when replaying its cached reply Date: Thu, 19 Nov 2026 15:24:24 +0100 Message-ID: <2026111950-CVE-2026-99366-5dd4@gregkh> X-Mailer: git-send-email 2.56.0 Reply-To: , X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4710; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=fI41Y1FLOusq1ADjwnX7PIntGUpU8LuApzl3SWI06ME=; b=owGbwMvMwCRo6H6F97bub03G02pJDFn/2cqbv9i+TRPWiJ39412L3CvRdbxH1mz8Zf8ixKYhf PLsiZ0iHbEsDIJMDLJiiixftvEc3V9xSNHL0PY0zBxWJpAhDFycAjCRwBcMCzb5mTxVMDO21F8j pDnJsMfPWPKNC8OCra+++B7h/W3TbnDsxt01MxW1ny7WAgA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit From: Greg Kroah-Hartman Description =========== In the Linux kernel, the following vulnerability has been resolved: nfsd: don't modify a session slot when replaying its cached reply nfsd4_sequence() claims a session slot by setting NFSD4_SLOT_INUSE under nn->client_lock. A reply served from the slot's reply cache does not claim it, and that distinction lived only in cstate->status, which nfsd4_sequence() set to nfserr_replay_cache. Commit cc028a10a48c ("NFSD: Hoist status code encoding into XDR encoder functions") moved nfsd4_proc_compound()'s cstate->status assignment below the out: label, and the replay path's goto out was the one path that relied on skipping it. The test in nfsd4_sequence_done() therefore no longer identifies a replay, and every replay now stores its reply and clears NFSD4_SLOT_INUSE as though it owned the slot. NFSD4_SLOT_INUSE is the interlock: check_slot_seqid() rejects every sequence id for a slot that is in use, before replay_matches_cache() runs. A replay never sets it, so two replays can be in flight on the same slot at once. One can read slot->sl_cred under nn->client_lock while the other's completion frees and rebuilds it from the XDR encoder without that lock. Two completions can also collide with each other and release the same group_info twice. free_svc_cred() leaves cr_uid, cr_gid and cr_flavor intact, so the reader passes every earlier test in same_creds() and dereferences a NULL cr_group_info. >>From a 6.12.91 production server: BUG: kernel NULL pointer dereference, address: 0000000000000004 CPU: 63 UID: 0 PID: 39015 Comm: nfsd RIP: 0010:same_creds+0x38/0xa0 [nfsd] RDX: 0000000000000000 Call Trace: nfsd4_sequence+0x6a8/0x910 [nfsd] nfsd4_proc_compound+0x345/0x670 [nfsd] nfsd_dispatch+0x100/0x220 [nfsd] svc_process_common+0x311/0x700 [sunrpc] svc_process+0x131/0x1c0 [sunrpc] svc_recv+0x7ef/0x9c0 [sunrpc] nfsd+0xa3/0x100 [nfsd] Kernel panic - not syncing: Fatal exception Since v6.14 a live session's slot table can shrink, and the unowned store becomes a use-after-free write. nfsd4_sequence() defers the shrink while a slot is in use, but it tests NFSD4_SLOT_INUSE, which a replay does not set, so free_session_slots() can kfree() the slot the replay still holds in cstate->slot. Record the claim in cstate->slot_owned when nfsd4_sequence() accepts a request and test that in nfsd4_sequence_done(), so only the request that claimed the slot updates its cached reply and clears NFSD4_SLOT_INUSE. svc_generic_init_request() zeroes the compound response before each request, so the flag starts clear. The Linux kernel CVE team has assigned CVE-2026-99366 to this issue. Affected and fixed versions =========================== Issue introduced in 5.10 with commit cc028a10a48c3c555d7772d02f56eea9f86fdf79 and fixed in 6.12.117 with commit 065764e256ebff20201dca5bc6ff075c6cb62e17 Issue introduced in 5.10 with commit cc028a10a48c3c555d7772d02f56eea9f86fdf79 and fixed in 6.18.61 with commit 0b5149b7ad8ccd64c61e887e2cf1af068b6210c9 Issue introduced in 5.10 with commit cc028a10a48c3c555d7772d02f56eea9f86fdf79 and fixed in 7.3.2 with commit 4e3c12151f13c4e51eb381f9377835fb94b9f56a Issue introduced in 5.10 with commit cc028a10a48c3c555d7772d02f56eea9f86fdf79 and fixed in 7.4-rc1 with commit 2987838317501ff67b672ac2a441fe34b7729f3d Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2026-99366 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: fs/nfsd/nfs4state.c fs/nfsd/xdr4.h Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/065764e256ebff20201dca5bc6ff075c6cb62e17 https://git.kernel.org/stable/c/0b5149b7ad8ccd64c61e887e2cf1af068b6210c9 https://git.kernel.org/stable/c/4e3c12151f13c4e51eb381f9377835fb94b9f56a https://git.kernel.org/stable/c/2987838317501ff67b672ac2a441fe34b7729f3d