From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DC41606A32A for ; Fri, 20 Nov 2026 12:58:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=nC8rVVr3 Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7804A10E8D1; Fri, 20 Nov 2026 12:58:10 +0000 (UTC) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA66B10E8D1 for ; Fri, 20 Nov 2026 12:57:19 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 0A59360D0B; Fri, 20 Nov 2026 12:57:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5A541F000C4; Fri, 20 Nov 2026 12:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795179438; bh=VYucq2PwnCz02xKSxZC+DMplYOpyNrPS8Zl6oImhRj8=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=nC8rVVr3IL90YNZ3xzPbnBA+fQidPpJcSdv2kbPnWDzCx9D9wsd2wriURuZJOHCKa HVNKJ3ZGTQI9hok4ELZnr/uzFkx8IzmDJ9WWBtWFdWXrldNpbbzpVyHysy4Z+Iziz9 FCWkkQhwFaly31Q8UAEEZf5oroA5yWejubKQMB3Dr/fBs0nvMrE8Kop0IC6v1PDLa8 4gIvQ5W1WSJWMYLBX35aD8r3aKRr+r52OFX14FxVfFSjfRxFMn8Mej1sOHwMr5/Dqo clYOBMfOWTMcUZRvAyCHmZVvlnqH8ofp3+m7bFM+Do89BB+OB+X/Uy39rG0y6IaKF9 cHfKKN99qFP0w== From: Maxime Ripard Date: Fri, 20 Nov 2026 13:55:26 +0100 Subject: [PATCH v9 34/42] drm/tidss: kms: Hook up hardware state readout X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261120-drm-state-readout-v9-34-a67c2b45b8ec@kernel.org> References: <20261120-drm-state-readout-v9-0-a67c2b45b8ec@kernel.org> In-Reply-To: <20261120-drm-state-readout-v9-0-a67c2b45b8ec@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jyri Sarha , Tomi Valkeinen Cc: Devarsh Thakkar , dri-devel@lists.freedesktop.org, Maxime Ripard X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2349; i=mripard@kernel.org; h=from:subject:message-id; bh=HPhMeeKvlNcK9qsa3vJAbfoudsb/8TlQ7JZz3cx2y5Y=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDNkMzoa/ffd2ns6SeLtMNDg/cumqdbPb/tcVO+7Y/3f/5 8MzLa/t75jKwiDMySArpsjyRCbs9PL2xVUO9it/wMxhZQIZwsDFKQATYdBhbPj3XVgi9knI5D9c Bun/LN6cE1z++5aTrYnpT6+zUZOW1k5W6J/558h1YfU5i/K3xi9+fpCxTpfTx8ZVPfp+k76vRaf /mpaU69Jhb5mU3njd1zvlcY7d45nY0X+MYnaMCyczME6+W6oAAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "dri-devel" X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 The CRTC, plane and bridge state readout hooks of the tidss driver are only called by the KMS core if the device opts in to the state readout infrastructure. Set drm_mode_config_funcs.atomic_sro_readout_state to drm_atomic_helper_sro_readout_state(), and drm_mode_config_helper_funcs.atomic_sro_build_state and drm_mode_config_helper_funcs.atomic_sro_install_state to drm_atomic_helper_sro_build_state() and drm_atomic_helper_sro_install_state() respectively, which implement the standard readout sequence on top of the per-object hooks. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tidss/tidss_kms.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c index 9d9cd1990630..77294fe34df0 100644 --- a/drivers/gpu/drm/tidss/tidss_kms.c +++ b/drivers/gpu/drm/tidss/tidss_kms.c @@ -4,10 +4,12 @@ * Author: Tomi Valkeinen */ #include #include +#include +#include #include #include #include #include #include @@ -62,11 +64,13 @@ static void tidss_atomic_commit_tail(struct drm_atomic_commit *old_state) tidss_runtime_put(tidss); } static const struct drm_mode_config_helper_funcs mode_config_helper_funcs = { - .atomic_commit_tail = tidss_atomic_commit_tail, + .atomic_commit_tail = tidss_atomic_commit_tail, + .atomic_sro_build_state = drm_atomic_helper_sro_build_state, + .atomic_sro_install_state = drm_atomic_helper_sro_install_state, }; static int tidss_atomic_check(struct drm_device *ddev, struct drm_atomic_commit *state) { @@ -131,10 +135,11 @@ static void tidss_hw_reset(struct drm_device *dev) static const struct drm_mode_config_funcs mode_config_funcs = { .fb_create = drm_gem_fb_create, .atomic_check = tidss_atomic_check, .atomic_commit = drm_atomic_helper_commit, + .atomic_sro_readout_state = drm_atomic_helper_sro_readout_state, .hw_reset = tidss_hw_reset, }; static const char * const tidss_internal_bridge_compatibles[] = { "ti,j721e-dsi", -- 2.56.1