From: Joshua Crofts <crofts@kernel.org>
To: "Bin Liu" <b-liu@ti.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Felipe Balbi" <balbi@ti.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Sashiko <sashiko-bot@kernel.org>,
stable@vger.kernel.org, Joshua Crofts <crofts@kernel.org>
Subject: [PATCH v2] usb: musb: fix use-after-free in musb_remove()
Date: Fri, 20 Nov 2026 15:23:14 +0100 [thread overview]
Message-ID: <20261120-usb-uaf-fix-v2-1-cc3cb2a38ad5@kernel.org> (raw)
Currently in musb_remove(), musb_platform_exit() drops the PHY refcount
before usb_phy_shutdown() is called, causing a use-after-free bug.
Reorder the function so that usb_phy_shutdown() is called before
musb_platform_exit(), the same way as musb_init_controller() does in the
error path.
Reported-by: Sashiko <sashiko-bot@kernel.org>
Closes: https://sashiko.dev/#/bug/linux-d180c2b9-0006-4638-a22b-13df8c201235
Fixes: 39cee200c23e ("usb: musb: core: call init and shutdown for the usb phy")
Cc: stable@vger.kernel.org
Signed-off-by: Joshua Crofts <crofts@kernel.org>
---
Changes in v2:
- Rebased on usb-linus branch
- Link to v1: https://lore.kernel.org/linux-usb/20261107-usb-uaf-fix-v1-1-ba33689d0ca3@kernel.org
---
drivers/usb/musb/musb_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index eb29ae47697c..1715ff1dd424 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -2651,6 +2651,7 @@ static void musb_remove(struct platform_device *pdev)
cancel_delayed_work_sync(&musb->finish_resume_work);
cancel_delayed_work_sync(&musb->deassert_reset_work);
+ usb_phy_shutdown(musb->xceiv);
musb_platform_exit(musb);
pm_runtime_dont_use_autosuspend(musb->controller);
@@ -2659,7 +2660,6 @@ static void musb_remove(struct platform_device *pdev)
musb_phy_callback = NULL;
if (musb->dma_controller)
musb_dma_controller_destroy(musb->dma_controller);
- usb_phy_shutdown(musb->xceiv);
musb_free(musb);
device_init_wakeup(dev, 0);
}
---
base-commit: 81fbc49e54cd8a8d10677878cc98a76d44797ea8
change-id: 20261120-usb-uaf-fix-ff4cbe6c4105
Best regards,
--
Joshua Crofts <crofts@kernel.org>
next reply other threads:[~2026-11-20 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 14:23 Joshua Crofts [this message]
2026-11-20 14:37 ` [PATCH v2] usb: musb: fix use-after-free in musb_remove() sashiko-bot
2026-11-20 14:51 ` Johan Hovold
2026-11-20 14:56 ` Joshua Crofts
2026-11-20 14:58 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120-usb-uaf-fix-v2-1-cc3cb2a38ad5@kernel.org \
--to=crofts@kernel.org \
--cc=b-liu@ti.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.