From: Andre Przywara <andre.przywara@arm.com>
To: Alastair D'Silva <alastair@d-silva.org>
Cc: u-boot@lists.u-boot-project.org, Tom Rini <trini@konsulko.com>,
Hans de Goede <hdegoede@redhat.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Lukasz Majewski <lukma@nabladev.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Peng Fan <peng.fan@nxp.com>,
Tanmay Kathpalia <tanmay.kathpalia@altera.com>,
Yixun Lan <dlan@kernel.org>, Yixun Lan <dlan@gentoo.org>,
Enzo Adriano <enzo.adriano.code@gmail.com>,
Junhui Liu <junhui.liu@pigmoral.tech>
Subject: Re: [PATCH 01/26] power: regulator: axp: Fix AXP318W ELDO voltage mask
Date: Fri, 20 Nov 2026 01:06:49 +0100 [thread overview]
Message-ID: <20261120010649.3219583a@ryzen.lan> (raw)
In-Reply-To: <20261113023236.569054-2-alastair@d-silva.org>
On Fri, 13 Nov 2026 13:32:11 +1100
Alastair D'Silva <alastair@d-silva.org> wrote:
> On AXP318W, ELDO1-ELDO6 span 500 mV to 1500 mV in 25 mV steps (40 steps,
> selectors 0x00..0x28), requiring a 6-bit selector mask (0x3f) rather
> than the 5-bit mask (0x1f, max 0x1f -> 1275 mV) currently listed in
> axp318_regulators[].]
That is correct, but can you say what this fixes?
>
> Fixes: 71f07932756f ("power: regulator: add AXP318W support")
> Signed-off-by: Alastair D'Silva <alastair@d-silva.org>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
> drivers/power/regulator/axp_regulator.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/power/regulator/axp_regulator.c b/drivers/power/regulator/axp_regulator.c
> index 16d3a8f7f90..e425f3bf8b2 100644
> --- a/drivers/power/regulator/axp_regulator.c
> +++ b/drivers/power/regulator/axp_regulator.c
> @@ -227,12 +227,12 @@ static const struct axp_regulator_plat axp318_regulators[] = {
> { "dldo4", 0x22, BIT(3), 0x37, 0x1f, 500, 3400, 100, NA },
> { "dldo5", 0x22, BIT(4), 0x38, 0x1f, 500, 3400, 100, NA },
> { "dldo6", 0x22, BIT(5), 0x39, 0x1f, 500, 3400, 100, NA },
> - { "eldo1", 0x22, BIT(6), 0x3a, 0x1f, 500, 1500, 25, NA },
> - { "eldo2", 0x22, BIT(7), 0x3b, 0x1f, 500, 1500, 25, NA },
> - { "eldo3", 0x23, BIT(0), 0x3c, 0x1f, 500, 1500, 25, NA },
> - { "eldo4", 0x23, BIT(1), 0x3d, 0x1f, 500, 1500, 25, NA },
> - { "eldo5", 0x23, BIT(2), 0x3e, 0x1f, 500, 1500, 25, NA },
> - { "eldo6", 0x23, BIT(3), 0x3f, 0x1f, 500, 1500, 25, NA },
> + { "eldo1", 0x22, BIT(6), 0x3a, 0x3f, 500, 1500, 25, NA },
> + { "eldo2", 0x22, BIT(7), 0x3b, 0x3f, 500, 1500, 25, NA },
> + { "eldo3", 0x23, BIT(0), 0x3c, 0x3f, 500, 1500, 25, NA },
> + { "eldo4", 0x23, BIT(1), 0x3d, 0x3f, 500, 1500, 25, NA },
> + { "eldo5", 0x23, BIT(2), 0x3e, 0x3f, 500, 1500, 25, NA },
> + { "eldo6", 0x23, BIT(3), 0x3f, 0x3f, 500, 1500, 25, NA },
> { "swout1", 0x11, BIT(3), NA, NA, NA, NA, NA, NA },
> { "swout2", 0x11, BIT(4), NA, NA, NA, NA, NA, NA },
> { }
next prev parent reply other threads:[~2026-11-20 0:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 2:32 [PATCH 00/26] sunxi: Add Allwinner A733 (sun60i) and Orange Pi 4 Pro support Alastair D'Silva
2026-11-13 2:32 ` [PATCH 01/26] power: regulator: axp: Fix AXP318W ELDO voltage mask Alastair D'Silva
2026-11-20 0:06 ` Andre Przywara [this message]
2026-11-13 2:32 ` [PATCH 02/26] power: pmic: axp: Fix AXP318W sysreset shutdown register Alastair D'Silva
2026-11-13 2:32 ` [PATCH 03/26] power: axp: Extend AXP318W SPL support with DCDC6/7 and LDOs Alastair D'Silva
2026-11-13 2:32 ` [PATCH 04/26] dt-bindings: clk: sun60i-a733-ccu: Add Allwinner A733 support Alastair D'Silva
2026-11-13 2:32 ` [PATCH 05/26] mmc: sunxi: Scale data transfer timeout with transfer size Alastair D'Silva
2026-11-13 2:32 ` [PATCH 06/26] gpio: a733: add initial support Alastair D'Silva
2026-11-13 2:32 ` [PATCH 07/26] pinctrl: sunxi: " Alastair D'Silva
2026-11-13 2:32 ` [PATCH 08/26] clock: reset: " Alastair D'Silva
2026-11-13 2:32 ` [PATCH 09/26] clock: a733: implement support for mmc/uart Alastair D'Silva
2026-11-13 2:32 ` [PATCH 10/26] sunxi: mmc: enable support for A733 Alastair D'Silva
2026-11-13 2:32 ` [PATCH 11/26] sunxi: a733: uart: setup serial console Alastair D'Silva
2026-11-13 2:32 ` [PATCH 12/26] arm64: spl: Support disposable .init.rodata section after _image_binary_end Alastair D'Silva
2026-11-13 2:32 ` [PATCH 13/26] sunxi: fel: Add Allwinner A733 ERET FEL return support Alastair D'Silva
2026-11-19 23:53 ` Andre Przywara
2026-11-13 2:32 ` [PATCH 14/26] sunxi: dram: a733: Add ARC PMU register, ABI, and build definitions Alastair D'Silva
2026-11-13 2:32 ` [PATCH 15/26] sunxi: dram: a733: Add ARC PMU primitives, clock, telemetry, and CBT Alastair D'Silva
2026-11-13 2:32 ` [PATCH 16/26] sunxi: dram: a733: Add ARC PMU deskew and BIST training firmware Alastair D'Silva
2026-11-13 2:32 ` [PATCH 17/26] sunxi: dram: a733: Add ARC PMU 1D/2D eye " Alastair D'Silva
2026-11-13 2:32 ` [PATCH 18/26] sunxi: dram: a733: Add ARC PMU training state machine Alastair D'Silva
2026-11-13 2:32 ` [PATCH 19/26] sunxi: dram: a733: Add Allwinner A733 LPDDR5 DRAM driver Alastair D'Silva
2026-11-13 2:32 ` [PATCH 20/26] sunxi: sun60i: initial support for A733 SoC Alastair D'Silva
2026-11-13 2:32 ` [PATCH 21/26] doc: sunxi: Document Allwinner A733 LPDDR5 PMU architecture Alastair D'Silva
2026-11-13 2:32 ` [PATCH 22/26] phy: sunxi: Add Allwinner A733 Cadence Combo PHY driver Alastair D'Silva
2026-11-13 2:32 ` [PATCH 23/26] pci: sunxi: Add Allwinner A733 DesignWare PCIe host controller driver Alastair D'Silva
2026-11-13 2:32 ` [PATCH 24/26] sunxi: Add NVMe to distro boot targets Alastair D'Silva
2026-11-13 2:32 ` [PATCH 25/26] arm64: dts: allwinner: add A733 SoC description Alastair D'Silva
2026-11-13 2:32 ` [PATCH 26/26] sunxi: Add Xunlong Orange Pi 4 Pro board support Alastair D'Silva
2026-11-13 7:28 ` [PATCH 00/26] sunxi: Add Allwinner A733 (sun60i) and Orange Pi 4 Pro support Alastair D'Silva
2026-11-20 0:31 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120010649.3219583a@ryzen.lan \
--to=andre.przywara@arm.com \
--cc=alastair@d-silva.org \
--cc=dlan@gentoo.org \
--cc=dlan@kernel.org \
--cc=enzo.adriano.code@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=junhui.liu@pigmoral.tech \
--cc=lukma@nabladev.com \
--cc=neil.armstrong@linaro.org \
--cc=peng.fan@nxp.com \
--cc=tanmay.kathpalia@altera.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.