All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Saranya R <saranya.r@oss.qualcomm.com>
Cc: Thinh.Nguyen@synopsys.com, linux-usb@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] usb: dwc3: gadget: Fix spurious suspend event during HS link training
Date: Fri, 20 Nov 2026 13:34:20 +0100	[thread overview]
Message-ID: <2026112002-sapling-nail-396f@gregkh> (raw)
In-Reply-To: <20260907101236.1543438-1-saranya.r@oss.qualcomm.com>

On Mon, Sep 07, 2026 at 03:42:36PM +0530, Saranya R wrote:
> During HS link training, a spurious DWC3_DEVICE_EVENT_SUSPEND carrying
> link state U3 is fired before CONNECT_DONE completes enumeration. At
> this point gadget->speed is USB_SPEED_UNKNOWN since CONNECT_DONE has
> not yet run. Calling dwc3_gadget_suspend_interrupt() here triggers an
> unwanted composite_suspend, causing the charger framework to drop
> current to 2mA and then ramp back to 500mA on every USB connection.
> 
> Fix this by skipping suspend event processing when gadget->speed is
> USB_SPEED_UNKNOWN. This precisely targets the pre-enumeration window
> without affecting genuine suspend events: a real suspend at ADDRESS
> state (required for BC1.2 compliance) only arrives after CONNECT_DONE
> sets gadget->speed to the negotiated speed, so gadget->speed is no
> longer UNKNOWN at that point.
> 
> Signed-off-by: Saranya R <saranya.r@oss.qualcomm.com>
> ---
> 
> v2: remove Fixes tag and add cc stable

cc: stable was NOT added here.

> This issue observed on 6.12 kernel.

Please test a modern kernel version.

thanks,

greg k-h

      parent reply	other threads:[~2026-11-20 12:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 11:09 [PATCH] usb: dwc3: gadget: Fix spurious suspend event during HS link training Saranya R
2026-09-05  0:15 ` Thinh Nguyen
2026-09-07 10:12 ` [PATCH v2] " Saranya R
2026-09-11 23:44   ` Thinh Nguyen
2026-11-20 12:34   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026112002-sapling-nail-396f@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=saranya.r@oss.qualcomm.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.