From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88647606A320 for ; Fri, 20 Nov 2026 05:47:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=QH4u458i Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 51C1010EDE2; Fri, 20 Nov 2026 05:47:53 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9051910F074 for ; Fri, 20 Nov 2026 05:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1795153661; x=1826689661; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=J3mT8quYw3Vm25z+1kZQkx0AQu3CIqpgU5ATRuOw38A=; b=QH4u458iSDr8O4mwaX88EpI9PfowCqqhe1z3lO6bZGkNzohF35UQ2gdp nsaaeAxn4uKojB5JRtpQWBnXFMs3EsdpoVnrI7nJ6ilhll5TZ5igN+tR/ kYuXYPEgNyYtrp2MCl0Iyv98FbtHwzLEeGkutVlJZ51jnMgrWyOMinr1g CVAEpnKqz11IsBEv4m28vXdTFbZMDO/mNabX6Zo0Ywt5/YZ3HuYhn1nO4 /Icb0CWh4WOyja5nIC2GWBqUG7vUBY/wIg3HCtSlc4xpdlMHoGAUcsZLo GM2hfmy2J0EvC11GyPjlRcpHsf9QtpkVkS+UJJkfubW6sizPEzerOFijl A==; X-CSE-ConnectionGUID: LXaucpM5TOSZ29vGiRM1sw== X-CSE-MsgGUID: vn6UwnUORhiDRoP5aHo/jw== X-IronPort-AV: E=McAfee;i="6800,10657,11971"; a="4018536" X-IronPort-AV: E=Sophos;i="6.27,222,1787036400"; d="scan'208";a="4018536" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2026 21:47:18 -0800 X-CSE-ConnectionGUID: hEYNDnNhR9iLpsWCrkafCQ== X-CSE-MsgGUID: Ai1ZVBGpSj6OtlmrsQmIDg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,222,1787036400"; d="scan'208";a="10617168" Received: from dut4463arlhx.fm.intel.com ([10.105.10.189]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2026 21:47:17 -0800 From: Stuart Summers To: Cc: rodrigo.vivi@intel.com, riana.tauro@intel.com, anoop.c.vijay@intel.com, matthew.d.roper@intel.com, fei.yang@intel.com, intel-xe@lists.freedesktop.org, Stuart Summers Subject: [PATCH 15/16] drm/xe: Allow probe without a primary GT Date: Fri, 20 Nov 2026 05:47:26 +0000 Message-ID: <20261120054712.377573-33-stuart.summers@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261120054712.377573-18-stuart.summers@intel.com> References: <20261120054712.377573-18-stuart.summers@intel.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Intel-xe" X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Probe required a graphics IP and a primary GT, so the media only combination the gt_types_allowed configfs attribute can ask for was rejected outright. Require instead that something is left to drive: at least one of the two IPs has to be detected, and every tile has to end up with at least one GT. The dgpu concern the old comment raised is covered by VRAM being a graphics IP property, so a device without one has no VRAM to manage. Signed-off-by: Stuart Summers --- drivers/gpu/drm/xe/xe_pci.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c index b8dcb224e306..31dbd5a32d65 100644 --- a/drivers/gpu/drm/xe/xe_pci.c +++ b/drivers/gpu/drm/xe/xe_pci.c @@ -1060,11 +1060,11 @@ static int xe_probe_ips(struct xe_device *xe, } /* - * If we couldn't detect the graphics IP, that's considered a fatal - * error and we should abort driver load. Failing to detect media - * IP is non-fatal; we'll just proceed without enabling media support. + * Either IP on its own is enough to go on with. Only a device where + * neither could be detected is a fatal error, since there would be + * nothing left to drive. */ - if (!probed_info->graphics_ip) + if (!probed_info->graphics_ip && !probed_info->media_ip) return -ENODEV; return 0; @@ -1179,21 +1179,14 @@ static int xe_info_init(struct xe_device *xe, if (IS_ERR(tile->primary_gt)) return PTR_ERR(tile->primary_gt); - /* - * It's not currently possible to probe a device with the - * primary GT disabled. With some work, this may be future in - * the possible for igpu platforms (although probably not for - * dgpu's since access to the primary GT's BCS engines is - * required for VRAM management). - */ - if (!tile->primary_gt) { - drm_err(&xe->drm, "Cannot probe device with without a primary GT\n"); - return -ENODEV; - } - tile->media_gt = alloc_media_gt(tile, media_desc); if (IS_ERR(tile->media_gt)) return PTR_ERR(tile->media_gt); + + if (!tile->primary_gt && !tile->media_gt) { + xe_tile_err(tile, "Cannot probe tile without any GT\n"); + return -ENODEV; + } } /* -- 2.43.0