All of lore.kernel.org
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
Cc: SJ Park <sj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	damon@lists.linux.dev, linux-mm@kvack.org
Subject: [RFC PATCH 3/4] mm/damon/reclaim: disable watermarks by default
Date: Thu, 19 Nov 2026 22:07:37 -0800	[thread overview]
Message-ID: <20261120060741.92121-4-sj@kernel.org> (raw)
In-Reply-To: <20261120060741.92121-1-sj@kernel.org>

DAMON_RECLAIM's free memory based watermarks features were introduced as
a safe guard for wrongly-tuned coldness threshold (min_age).  The
default watermark values were chosen to let users easily understand how
those can be set and tuned.  The default values are never meant to be
used as are.  DAMON_RECLAIM is later updated to enable PSI-driven
coldness threshold auto-tuning by default.  When the auto-tuning is
enabled, having the watermarks with the default values makes no sense.
Disable the watermarks by default.

Signed-off-by: SJ Park <sj@kernel.org>
---
 mm/damon/reclaim.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c
index d297b1596704b..a8b18f51e99d5 100644
--- a/mm/damon/reclaim.c
+++ b/mm/damon/reclaim.c
@@ -103,12 +103,13 @@ module_param(quota_autotune_feedback, ulong, 0600);
 static bool autotune_monitoring_intervals __read_mostly = true;
 module_param(autotune_monitoring_intervals, bool, 0600);
 
+/* Watermarks are effectively disabled by default. */
 static struct damos_watermarks damon_reclaim_wmarks = {
 	.metric = DAMOS_WMARK_FREE_MEM_RATE,
 	.interval = 5000000,	/* 5 seconds */
-	.high = 500,		/* 50 percent */
-	.mid = 400,		/* 40 percent */
-	.low = 200,		/* 20 percent */
+	.high = 1000,		/* 100 percent */
+	.mid = 1000,		/* 100 percent */
+	.low = 0,		/* 0 percent */
 };
 DEFINE_DAMON_MODULES_WMARKS_PARAMS(damon_reclaim_wmarks);
 
-- 
2.47.3


  parent reply	other threads:[~2026-11-20  6:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  6:07 [RFC PATCH 0/4] mm/damon/reclaim: enable auto-tuning features by default SJ Park
2026-11-20  6:07 ` [RFC PATCH 1/4] mm/damon/reclaim: enable monitoring intervals auto-tune " SJ Park
2026-11-20  6:21   ` sashiko-bot
2026-11-20  6:07 ` [RFC PATCH 2/4] mm/damon/reclaim: set memory PSI 0.05% as default quota goal SJ Park
2026-11-20  6:13   ` sashiko-bot
2026-11-20  6:07 ` SJ Park [this message]
2026-11-20  6:11   ` [RFC PATCH 3/4] mm/damon/reclaim: disable watermarks by default sashiko-bot
2026-11-20  6:07 ` [RFC PATCH 4/4] Docs/admin-guide/mm/damon/reclaim: update for changed default parameters SJ Park
2026-11-20  6:10   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120060741.92121-4-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.