From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.179 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795155670; b=4TWxNnvkfakcKu784CElRNOpt+AM8P2uynWivfdIVPpfsBIPl/mmROqGdabtv5M/KxJi Nrrw7EwDQ4HInar4gm4UQ92KuHCboX1wK2SsNYUQXgZq5Q0m7RfYRIn5k1MlnugLDIf3V IGiym7YkoNZXSI4LEJup/XWJ72flCW8QFA7L990SxC0s1l2pcThFdbr8TN52qVmuV8VXb zECR/PGxHYnew3Hw9TpqrcgU8ucy9yhtJ7QspA7lhW5C0aYf2BXICNenroSDZgfZPgTCJ YBtJR2hwEbJZRh+pk0iV1pnP2PRbAwbx9BDQ8oLE3kvWJG+lQPyGc/RSGU508ZEV+sw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795155670; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:MIME-Version:Content-Transfer-Encoding; bh=ylQ5NpR+7iB87MylzEu3DJ9CieEThMAM4Vq8MsEW9S4=; b=zyFS/QS7koBUSqW+EzJA1lRFXnaF1el2OIdSpiWmhAI34v/UqeribG3NeEtyEdXBRfiz tu0Zn3bSpa1jYM939t/X2wPRKuU9qlrf+TTOXssGpL/bYTWNmo7tvc+z0TQaA+te6Wwfi Z5wu06PoyU//UTZwQs1D3gTyR+f5iTaTz6UowmUkpU+2Sg4GZHmGfQQ57uXPPwEDbIYbw EHEHp8lMEoFdgGz6RT6ysTbzKE3evMTv5HRovvaKrICBSIp0Gpm3CtI2qqIlBT4Lvo+gd 196vndJfAgFT5O1+FvRi5JLt69O9X4Xn28Cln06tbcAOmI2UjRwV3mnbTPv3vThHkYg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=jf9CV78f; arc=none smtp.remote-ip=74.125.82.179 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B054860A2600 for ; Fri, 20 Nov 2026 06:21:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B054860A2600 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=jf9CV78f Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-3282db206d3so1442107eec.0 for ; Thu, 19 Nov 2026 22:21:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795155669; x=1795760469; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ylQ5NpR+7iB87MylzEu3DJ9CieEThMAM4Vq8MsEW9S4=; b=jf9CV78fTEHK77xABUNuLqeS77oUBYpR+16bljYgb0KLdAWnIC/IJI+3N04IHXm2Yc xciabRbXXTjGCK+TPK2aBYJ9r+9vAennl2WJGwAvxCC6ACdA3fbxP+Zoul6dm0x1GjSd lWLSGdMfwzub5nLl87rkdWrulgyYQ9zJlv0ufpxSqpXN+QchkFHOCJILENf9gwiEFBAI 7V7uqpre3uWfn7D9a1XitMGgfCp2C9XLDzS/TC5Vy7GKAXhFgMN3eNRDH0oDqsrIhaky vXMoB/AkH9LNqSmfgh6vvRRVrJ78mqMoDymPL/bkhgNgjJLbEazlcR2RdfLxD4MFWjvf t0ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795155669; x=1795760469; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ylQ5NpR+7iB87MylzEu3DJ9CieEThMAM4Vq8MsEW9S4=; b=XaSxuKJyIxNwVw/A3DrCICxwCZGJNSrKHBE8Scvarbxnz2cloBHf1DyFejdz18CFjP mN2keClVAE2MDfRRHUJD/x8dxXWvK/rDOhqcev+Go+ic0AF2Lw6hKAHqJXwn0IsmUqHN +asylVTa2TxBCeXP1pi18bSrTo4YHzTjpG3veu4lwXArxJ1rACJxMl6rioe/cbuSMMsO gbEr6IBZdAJXZmgfXnm+OkkQncQb1UWA7gK992wst8kp5wn1sxPl/ywTMFtRr1KLMgfE ZLmyxIMS+cKMdtYJu2MkXIDMTeOiASfUakegAworsMenyk5UYzrqVNs1mWGMt/sFSYU+ 2ANQ== X-Gm-Message-State: APuU4Z8OpEmqp9G8RQUpIWHUD0ALzY9uVP0AEoRvXodION7iuqJaPS4H lwhjjrFd2X/exCgpqWwXyqAuHiOXr2eogbb83URAxZ1JGkIQk1ZkzSPq X-Gm-Gg: AZFdTZc5CDS9LpCdbZ1ur4qot72hwSoZooaM/1v3ilfPUqQCVwKRbFesz+1NH5mwvLx 7XN5Vr9Yvmk7F+VKlahxcBzCKHTzazkv2JofLmKTg9pVcMseN8SCnEx/AUH/QbV9edaxRRtwWsY 07GtVcoMqMHMCvmLBVLgM28MhieQXYnCJ72epZ6eOZa/SIOETtMcPc6TMIApLaj2tnkPpB+XArY d3GgJmlQE/UWDQ4FfTkqdn7BP5nmCbM0qS0HzKzmxIqEM91rRnIekXhGLN2lXG4EROAvXsEsxlx imXo+nSOwHtAFc2IYE66DT7iOXAN+Udj9L1usrV8brcj6J/c2jALIw/vcKQp1+//ys/ZYz8I1fq iR+n1OZcEExuBKcsu3f/Es2KVjbjzlH06fWSdA6tkagO+nDBkmdSnHPXKWcsrGM2gz9as+ALYvA iBVjZMec8b2Ha8XBhVGaKM7r5R/M3+C+14Gl+FTU8kaheMCIr92udWwDePyfsrff1A1DwqP8CpD C5i4/GhC4QXQXIjgDojQZcKgIdFMjptu37fZRJC/FF0i34ZsEJ88EL+UzXqcXmXCzaKArHJ8lbX uJ5W1r/F2fQJ93opQ+yYwtCVaBtO6MS/44ISwizUZyk8w7726g== X-Received: by 2002:a05:693c:80cd:b0:385:b8f4:756a with SMTP id 5a478bee46e88-385b8f47b36mr999820eec.12.1795155668669; Thu, 19 Nov 2026 22:21:08 -0800 (PST) Received: from G7XWH7K1F3 ([139.177.225.240]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-385666e99fdsm5476880eec.5.2026.11.19.22.21.04 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 19 Nov 2026 22:21:08 -0800 (PST) From: Zhao Li To: Marcel Holtmann , Luiz Augusto von Dentz Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Michael McAllister , stable@vger.kernel.org, Zhao Li Subject: [PATCH v2] Bluetooth: hci_serdev: stop write_work before closing the port Date: Fri, 20 Nov 2026 14:20:48 +0800 Message-ID: <20261120062048.40310-1-enderaoelyther@gmail.com> X-Mailer: git-send-email 2.56.1 X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With HCI_QUIRK_NON_PERSISTENT_SETUP, hci_uart_close() clears HCI_UART_PROTO_READY without hu->proto_lock and closes the serdev port without waiting for write_work. The hci_uart_flush() just before it re-enables write_work and may replay a recorded wakeup, and hci_uart_tx_wakeup() queues it from any caller that passed the HCI_UART_PROTO_READY test, such as the serdev write_wakeup callback. write_work can then call ttyport_write_buf() while ttyport_close() releases the tty, so it writes through a released tty. A partial frame that write_work leaves in hu->tx_skb also survives into the next open, which flushes nothing, and would be sent first to the controller after it is powered on again. Quiesce the transmit path as hci_uart_unregister_device() does: clear HCI_UART_PROTO_READY under percpu_down_write() so that no wakeup is in flight, cancel write_work, free the leftover frame, then close the port. A wakeup sets HCI_UART_SENDING and HCI_UART_TX_WAKEUP before it queues write_work, so clear both after the cancel: a work cancelled while still pending would leave SENDING set, and the next open, which reuses hu, would never queue write_work again. Found by code review. Compile-tested with W=1. Fixes: de8892df72be ("Bluetooth: hci_serdev: Close UART port if NON_PERSISTENT_SETUP is set") Cc: stable@vger.kernel.org Signed-off-by: Zhao Li --- v2: - Clear HCI_UART_SENDING and HCI_UART_TX_WAKEUP after cancelling write_work. A pending write_work cancelled there left SENDING set, so the next power-on never queued write_work (Sashiko's review of v1). v1: https://lore.kernel.org/linux-bluetooth/20261118124821.3990-1-enderaoelyther@gmail.com/ Before 6.16 the quirk test in hci_uart_close() reads test_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks); with that context line the patch applies to 6.12.y, 6.6.y, 6.1.y, 5.15.y and 5.10.y. It applies as is to 6.18.y and 7.3.y. No new W=1, sparse or smatch warnings. AI assistance was used. drivers/bluetooth/hci_serdev.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/bluetooth/hci_serdev.c b/drivers/bluetooth/hci_serdev.c index 194f11251cc5..a5e4b3d32144 100644 --- a/drivers/bluetooth/hci_serdev.c +++ b/drivers/bluetooth/hci_serdev.c @@ -164,7 +164,20 @@ static int hci_uart_close(struct hci_dev *hdev) * open may drain the battery. */ if (hci_test_quirk(hdev, HCI_QUIRK_NON_PERSISTENT_SETUP)) { + percpu_down_write(&hu->proto_lock); clear_bit(HCI_UART_PROTO_READY, &hu->flags); + percpu_up_write(&hu->proto_lock); + + cancel_work_sync(&hu->write_work); + clear_bit(HCI_UART_SENDING, &hu->tx_state); + clear_bit(HCI_UART_TX_WAKEUP, &hu->tx_state); + + /* Do not send a stale partial frame after the next open. */ + if (hu->tx_skb) { + kfree_skb(hu->tx_skb); + hu->tx_skb = NULL; + } + serdev_device_close(hu->serdev); } base-commit: 1d79f61152c315e30e758116e525871732181a98 -- 2.56.1