From: Roland Schober <rolandschober1968@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Roland Schober <rolandschober1968@gmail.com>
Subject: [PATCH BlueZ v4 02/10] monitor: Fix data length of LE PA Report decoding
Date: Fri, 20 Nov 2026 07:38:48 +0100 [thread overview]
Message-ID: <20261120063856.16585-3-rolandschober1968@gmail.com> (raw)
In-Reply-To: <20261120063856.16585-1-rolandschober1968@gmail.com>
The LE Periodic Advertising Report decoder passes Data_Length from the
event to the advertising data decoder without checking it against the
size of the event, so a truncated event makes it decode octets which
are not part of it, and octets beyond Data_Length are dropped silently:
> HCI Event: LE Meta Event (0x3e) plen 8
LE Periodic Advertising Report (0x0f)
...
Data length: 1
Data[1]:
00 .
Report a length which does not match the event as invalid and dump
the remaining octets instead:
Data length: 1
invalid data length
Fixes: 5441a5b91a08 ("monitor: Decode LE Periodic Advertising Report Event")
Assisted-by: Claude:claude-opus-5-5
---
monitor/packet.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/monitor/packet.c b/monitor/packet.c
index 4ff24092e..0e40300fd 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -13957,6 +13957,13 @@ static void le_pa_report_evt(struct timeval *tv, uint16_t index,
print_field("Data status: %s%s%s", color_on, str, COLOR_OFF);
print_field("Data length: %u", evt->data_len);
+
+ if (evt->data_len != size - sizeof(*evt)) {
+ print_text(COLOR_ERROR, "invalid data length");
+ packet_hexdump(evt->data, size - sizeof(*evt));
+ return;
+ }
+
print_eir("Data", evt->data, evt->data_len, true);
}
--
2.47.3
next prev parent reply other threads:[~2026-11-20 6:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 6:38 [PATCH BlueZ v4 00/10] monitor: Decode Periodic Advertising with Responses Roland Schober
2026-11-20 6:38 ` [PATCH BlueZ v4 01/10] monitor: Fix handle decoding of status_handle_rsp Roland Schober
2026-11-20 14:51 ` monitor: Decode Periodic Advertising with Responses bluez.test.bot
2026-11-20 6:38 ` Roland Schober [this message]
2026-11-20 6:38 ` [PATCH BlueZ v4 03/10] monitor: Fix PHY decoding of LE Ext Create Connection Roland Schober
2026-11-20 6:38 ` [PATCH BlueZ v4 04/10] monitor: Fix advertising handle of LE PA commands Roland Schober
2026-11-20 6:38 ` [PATCH BlueZ v4 05/10] monitor: Fix TX power and CTE Type of LE PA Report Roland Schober
2026-11-20 6:38 ` [PATCH BlueZ v4 06/10] monitor: Fix LE PAST Received decoding Roland Schober
2026-11-20 6:38 ` [PATCH BlueZ v4 07/10] monitor: Fix byte order of LE PA Sync Handle and Properties Roland Schober
2026-11-20 6:38 ` [PATCH BlueZ v4 08/10] monitor: Split LE PA Report decoding into helpers Roland Schober
2026-11-20 6:38 ` [PATCH BlueZ v4 09/10] monitor: Add PAwR HCI commands decoding Roland Schober
2026-11-20 6:38 ` [PATCH BlueZ v4 10/10] monitor: Add PAwR HCI events decoding Roland Schober
2026-11-20 15:34 ` [PATCH BlueZ v4 00/10] monitor: Decode Periodic Advertising with Responses Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120063856.16585-3-rolandschober1968@gmail.com \
--to=rolandschober1968@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.