From: Stefan Eichenberger <eichest@gmail.com>
To: trini@konsulko.com, ilias.apalodimas@linaro.org,
peng.fan@nxp.com, jh80.chung@samsung.com,
tanmay.kathpalia@altera.com, sbabic@nabladev.com,
festevam@gmail.com, uboot-imx@nxp.com,
francesco.dolcini@toradex.com, lukma@nabladev.com,
dlechner@baylibre.com, msp@baylibre.com,
stefan.eichenberger@toradex.com, Max.Merchel@ew.tq-group.com,
nora.schiffer@ew.tq-group.com, primoz.fiser@norik.com,
jbx6244@gmail.com, aford173@gmail.com,
cniedermaier@dh-electronics.com
Cc: u-boot@lists.u-boot-project.org
Subject: [PATCH v1 3/7] clk: imx: pllv3: do not touch the ENET output gate
Date: Fri, 20 Nov 2026 12:10:09 +0100 [thread overview]
Message-ID: <20261120111037.110741-4-eichest@gmail.com> (raw)
In-Reply-To: <20261120111037.110741-1-eichest@gmail.com>
From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
The PLLv3 enable and disable set and clear BM_PLL_ENABLE (bit 13) for
every PLL type. On PLL_ENET that bit is not a PLL enable but an output
gate: ENET1_125M_EN on i.MX6UL/ULL and the ENET clock output enable on
i.MX6Q/DL. Both SoC drivers already model it as their own gate clock
(enet1_ref_125m and pll6_enet, respectively), so the bit has two owners.
Enabling PLL6 for any of its other outputs turns that output on as well,
and disabling PLL6 clears it behind the gate's back.
Linux only handles the power bit for the ENET PLL. Do the same and leave
bit 13 to the SoC drivers. The PLL is still powered up and down through
BM_PLL_POWER.
Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
---
drivers/clk/imx/clk-pllv3.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c
index 8e67442844f..4a3f1d088dd 100644
--- a/drivers/clk/imx/clk-pllv3.c
+++ b/drivers/clk/imx/clk-pllv3.c
@@ -346,6 +346,8 @@ struct clk *imx_clk_pllv3(struct udevice *dev, enum imx_pllv3_type type,
case IMX_PLLV3_ENET:
drv_name = UBOOT_DM_CLK_IMX_PLLV3_ENET;
pll->ref_clock = 500000000;
+ /* Bit 13 is an output gate, modelled by the SoC driver */
+ pll->enable_bit = 0;
break;
default:
kfree(pll);
--
2.56.1
next prev parent reply other threads:[~2026-11-20 13:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 11:10 [PATCH v1 0/7] colibri-imx6ull: fix the Ethernet PHY detection Stefan Eichenberger
2026-11-20 11:10 ` [PATCH v1 1/7] clk: imx: imx6ul: fix the enet clock gate register Stefan Eichenberger
2026-11-20 11:10 ` [PATCH v1 2/7] clk: imx: pllv3: wait for the ENET PLL to lock Stefan Eichenberger
2026-11-20 11:10 ` Stefan Eichenberger [this message]
2026-11-20 11:10 ` [PATCH v1 4/7] clk: imx: imx6ul: add the enet clock tree Stefan Eichenberger
2026-11-20 11:10 ` [PATCH v1 5/7] board: toradex: colibri-imx6ull: drop the static serial device Stefan Eichenberger
2026-11-20 11:10 ` [PATCH v1 6/7] arm: dts: imx6ull-colibri: migrate to OF_UPSTREAM Stefan Eichenberger
2026-11-20 11:10 ` [PATCH v1 7/7] board: toradex: colibri-imx6ull: enable the clock framework Stefan Eichenberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120111037.110741-4-eichest@gmail.com \
--to=eichest@gmail.com \
--cc=Max.Merchel@ew.tq-group.com \
--cc=aford173@gmail.com \
--cc=cniedermaier@dh-electronics.com \
--cc=dlechner@baylibre.com \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jbx6244@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=lukma@nabladev.com \
--cc=msp@baylibre.com \
--cc=nora.schiffer@ew.tq-group.com \
--cc=peng.fan@nxp.com \
--cc=primoz.fiser@norik.com \
--cc=sbabic@nabladev.com \
--cc=stefan.eichenberger@toradex.com \
--cc=tanmay.kathpalia@altera.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.