From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67B3C606A32A for ; Fri, 20 Nov 2026 12:16:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=VDmynHfn Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xUNWz-0006PD-4G; Fri, 20 Nov 2026 07:15:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xUNWi-0006Hu-51 for qemu-devel@nongnu.org; Fri, 20 Nov 2026 07:15:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xUNWg-0006Fj-8I for qemu-devel@nongnu.org; Fri, 20 Nov 2026 07:15:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1795176933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TWwT9612ZW0vbY2P/IQBX7G3/db7VfF5dQu5dZHqZWI=; b=VDmynHfnOZ50UqtWzL7bQgy7WD3DtfFXLuibwU9aEOFrNFfQ2RZasTXetVVKJ1KRHyux4n wt5pVFUgyould7tavkh494j52evpM+D+c1jE1TALU9HKiAwV8y0J813o7eAJYoqwn4rRUN +NOTTj+t6+kGYk55YlmD4CQ9KgatqYQ= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-297-414XcubEPyGRqf7SSj1Oog-1; Fri, 20 Nov 2026 12:15:28 +0000 X-MC-Unique: 414XcubEPyGRqf7SSj1Oog-1 X-Mimecast-MFC-AGG-ID: 414XcubEPyGRqf7SSj1Oog_1795176926 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1DFCA18002CC; Fri, 20 Nov 2026 12:15:26 +0000 (UTC) Received: from berrange.csb (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C868830000E3; Fri, 20 Nov 2026 12:15:21 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Pierrick Bouvier , Zhao Liu , Peter Maydell , Matthew Rosato , Halil Pasic , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Strahinja Jankovic , Niek Linnenbank , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , "Michael S. Tsirkin" , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Thomas Huth , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Eric Farman Subject: [PATCH 04/12] tests/functional: add Accept header when downloading assets Date: Fri, 20 Nov 2026 12:14:50 +0000 Message-ID: <20261120121458.3723625-5-berrange@redhat.com> In-Reply-To: <20261120121458.3723625-1-berrange@redhat.com> References: <20261120121458.3723625-1-berrange@redhat.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 elinux.org is currently triggering an Anubis challenge for requests to download assets. After comparing the headers that curl sends, it was narrowed down to the omission of an "Accept" header. A missing "Accept" header is a rule that Anubis added a year ago which is known to hit python's urllib: https://github.com/TecharoHQ/anubis/issues/1346 the bug indicates the rule was removed by default at that time, however, rules have evolved further since then and look like they are hitting our downloads. Adding the header is simple & harmless. Signed-off-by: Daniel P. Berrangé --- tests/functional/qemu_test/asset.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tests/functional/qemu_test/asset.py b/tests/functional/qemu_test/asset.py index 0abd89e0a38..ffa01aba2fb 100644 --- a/tests/functional/qemu_test/asset.py +++ b/tests/functional/qemu_test/asset.py @@ -137,7 +137,16 @@ def _try_to_fetch(self, tmp_cache_file): for _retries in range(3): try: with tmp_cache_file.open("xb") as dst: - with urllib.request.urlopen(self.url) as resp: + req = urllib.request.Request( + self.url, + headers={ + # Workaround Anubis challenge which some sites + # trigger when Accept is missing: + # https://github.com/TecharoHQ/anubis/issues/1346 + "Accept": "*/*", + } + ) + with urllib.request.urlopen(req) as resp: copyfileobj(resp, dst) length_hdr = resp.getheader("Content-Length") -- 2.56.1