From: Rustam Mustafin <rmustafin@cloudlinux.com>
To: Peter Huewe <peterhuewe@gmx.de>, Jarkko Sakkinen <jarkko@kernel.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Shuah Khan <shuah@kernel.org>,
Jaewon Yang <yong010301@gmail.com>,
linux-integrity@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Rustam Mustafin <rmustafin@cloudlinux.com>,
stable@vger.kernel.org
Subject: [PATCH v2 1/2] tpm: Track the response read position internally
Date: Fri, 20 Nov 2026 19:16:13 +0700 [thread overview]
Message-ID: <20261120121614.978396-2-rmustafin@cloudlinux.com> (raw)
In-Reply-To: <20261120121614.978396-1-rmustafin@cloudlinux.com>
tpm_common_read() indexes data_buffer with the caller supplied *off.
A read issued through io_uring reaches the driver with that offset:
loop_rw_iter() passes &ki_pos to ->read(). This allows out-of-bounds
reads and zeroing of kernel memory:
BUG: KASAN: slab-out-of-bounds in _copy_to_user+0x4b/0x70
Read of size 16 by task iou-wrk-148/149
Call Trace:
_copy_to_user+0x4b/0x70
tpm_common_read+0x16e/0x2c0
loop_rw_iter+0x235/0x5a0
__io_read+0xc6e/0x11a0
io_read+0x8a/0x180
A plain read() racing a write() reaches the same access: read()
samples f_pos before taking buffer_mutex, so it can consume a new
response from the offset left by the previous one:
BUG: KASAN: slab-out-of-bounds in _copy_to_user+0x4b/0x70
Read of size 75 by task trigger/151
Call Trace:
_copy_to_user+0x4b/0x70
tpm_common_read+0x16e/0x2c0
vfs_read+0x189/0xc00
ksys_read+0xf9/0x1d0
Replace *off with a read_pos member of struct file_priv. It is only
accessed under buffer_mutex, so the offset passed by the caller no
longer matters.
Fixes: 9488585b21be ("tpm: add support for partial reads")
Cc: stable@vger.kernel.org
Signed-off-by: Rustam Mustafin <rmustafin@cloudlinux.com>
---
drivers/char/tpm/tpm-dev-common.c | 11 ++++++-----
drivers/char/tpm/tpm-dev.h | 1 +
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/char/tpm/tpm-dev-common.c b/drivers/char/tpm/tpm-dev-common.c
index ee91f456f975..553fc6aca94d 100644
--- a/drivers/char/tpm/tpm-dev-common.c
+++ b/drivers/char/tpm/tpm-dev-common.c
@@ -107,6 +107,7 @@ static void tpm_timeout_work(struct work_struct *work)
mutex_lock(&priv->buffer_mutex);
priv->response_read = true;
priv->response_length = 0;
+ priv->read_pos = 0;
memset(priv->data_buffer, 0, sizeof(priv->data_buffer));
mutex_unlock(&priv->buffer_mutex);
wake_up_interruptible(&priv->async_wait);
@@ -149,21 +150,21 @@ ssize_t tpm_common_read(struct file *file, char __user *buf,
goto out;
}
- rc = copy_to_user(buf, priv->data_buffer + *off, ret_size);
+ rc = copy_to_user(buf, priv->data_buffer + priv->read_pos, ret_size);
if (rc) {
memset(priv->data_buffer, 0, TPM_BUFSIZE);
priv->response_length = 0;
ret_size = -EFAULT;
} else {
- memset(priv->data_buffer + *off, 0, ret_size);
+ memset(priv->data_buffer + priv->read_pos, 0, ret_size);
priv->response_length -= ret_size;
- *off += ret_size;
+ priv->read_pos += ret_size;
}
}
out:
if (!priv->response_length) {
- *off = 0;
+ priv->read_pos = 0;
timer_delete_sync(&priv->user_read_timer);
flush = true;
}
@@ -214,7 +215,7 @@ ssize_t tpm_common_write(struct file *file, const char __user *buf,
priv->response_length = 0;
priv->response_read = false;
- *off = 0;
+ priv->read_pos = 0;
/*
* If in nonblocking mode schedule an async job to send
diff --git a/drivers/char/tpm/tpm-dev.h b/drivers/char/tpm/tpm-dev.h
index f3742bcc73e3..34efb1ffa491 100644
--- a/drivers/char/tpm/tpm-dev.h
+++ b/drivers/char/tpm/tpm-dev.h
@@ -15,6 +15,7 @@ struct file_priv {
struct work_struct async_work;
wait_queue_head_t async_wait;
ssize_t response_length;
+ size_t read_pos;
bool response_read;
bool command_enqueued;
--
2.52.0
next prev parent reply other threads:[~2026-11-20 12:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 12:16 [PATCH v2 0/2] tpm: Track the response read position internally Rustam Mustafin
2026-11-20 12:16 ` Rustam Mustafin [this message]
2026-11-20 12:27 ` [PATCH v2 1/2] " Jarkko Sakkinen
2026-11-20 14:28 ` Rustam Mustafin
2026-11-20 14:50 ` Jarkko Sakkinen
2026-11-20 12:16 ` [PATCH v2 2/2] selftests: tpm2: test that io_uring reads ignore the file offset Rustam Mustafin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120121614.978396-2-rmustafin@cloudlinux.com \
--to=rmustafin@cloudlinux.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yong010301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.