From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.91 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795184158; b=RJ6gO6j2goFOf6T8M+FZjLJz+P8i+GtSvDmwTI0hlGeL41zA3buL3QkUcBxXPhfK8tst qNsI0OHhnfcgsXaNBGEab56XHu+cdtzKC5FlQLZ8fpao7TjuCOkBZVMbju0u4K1Qo9jyH tBKB28iNRfPSGGiTvVRQBHkl8vFnNo2zDGEg0hCsL7PoKUNH5qq+CqLS7yDYY47n70vBC Km7q84NgM32XG8WG5ekxxOcnpVwcTmY/sp7QCeurQxmQnn3ej0S26hYGdxz/5HsobKSGM NoY9IqEQ6FeByv0hNevBJeOi+8dRkYdLmo1cRvss5a1v38TJ76X7HGaJ7/Hcsex9n7w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795184158; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:Content-Type:MIME-Version: Content-Transfer-Encoding; bh=mFh+dAlIh89UuUDw9mliDsW1ZkhnuL29C/bIIMkCoV0=; b=RSzgQfC+FZqRiX4dBUSd7Bz3LU3CgKeherp0bj7GQeKugQxVrth8qrnauL1YLx1NXhnO /zpUczim8SnolME5XpdVDaw9iPAPnxgLk3NGIEWO8q934XjyXf7yD1CzKOmou7NrQF1yi keM3xl3egrcfnfZ3720yB+f+2cpdMQc/6Fh23eq30GUK2h9O9t1Sv7s3Qs/ryuM8onvKX bclkgcvS+Bd5pwETKlmAHGr1WmadQBW/6mC8SYC2cZ/RG/DGSYb9BkoJONogR4mqf+0St DF65W6gYijNI3un3EabZIIMOb9RPLeJy6NvBkFyqfh0GSV2EaQZoIApxJRdVn/nZupQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=okxXx9bj; arc=none smtp.remote-ip=91.218.175.91 Received: from mta0.migadu.com (out-91.mta0.migadu.com [91.218.175.91]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C57D7606A326 for ; Fri, 20 Nov 2026 14:15:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C57D7606A326 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=okxXx9bj X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=IxY/RMDxRESNWi5qd2dGR2bSpXOJklWLECvCrSdEVx8=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1795184156; v=1; x=1795788956; b=okxXx9bj/Cnv8Wk9oPUXQ0LPws6YoaC65B4oxmVwOYiCY+gZ2NTWdxjaIzAd0U9whuvyUiNe jfAfZLJVy54+HW8lcoeZG5aw0V5pKEIhBhBpyBw2XjtXlk54ftBtuMptZTcS+ov1PBlVw4D3/cF H1f8AywxUtwx1FYVOPLakLAQ= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 6bc853064f227431; Fri, 20 Nov 2026 14:15:55 +0000 X-Mizu-Trace-ID: 6bc853064f227431 X-Migadu-Flow: FLOW_OUT From: Luka Gejak To: Mehmet Fide , Ping-Ke Shih Cc: Bitterblue Smith , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, mehmet.fide@screeningeagle.com Subject: Re: [PATCH rtw-next v13 3/3] wifi: rtw88: time the countdown downloads from the TBTT Date: Fri, 20 Nov 2026 15:15:53 +0100 Message-ID: <20261120141554.68116-2-luka.gejak@linux.dev> X-Mailer: git-send-email 2.56.1 In-Reply-To: <20261118231940.3950-4-mehmet.fide@gmail.com> References: <20261118231940.3950-1-mehmet.fide@gmail.com> <20261118231940.3950-4-mehmet.fide@gmail.com> Content-Type: text/plain; charset="us-ascii" X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Mehmet, Thanks for the v13. One comment below. On November 19, 2026 12:19:40 AM GMT+01:00, Mehmet Fide wrote: > diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c > index 9d5df3e65b97..c24932d00e14 100644 > --- a/drivers/net/wireless/realtek/rtw88/fw.c > +++ b/drivers/net/wireless/realtek/rtw88/fw.c [ ... ] > + div_u64_rem(rtw_fw_read_tsf(rtwdev), interval, &rem); > + delay = interval - rem; > + if (delay < RTW_CSA_TBTT_MARGIN_US) > + delay += interval; [ ... ] > + usecs_to_jiffies(delay + > + RTW_CSA_TBTT_MARGIN_US)); Does the short interval case need a smaller margin here as well? With a beacon interval of 19 TU and a download that finishes 10 ms after a TBTT, the next two TBTTs are about 9.5 and 28.9 ms away. This queues the next step about 38.9 ms later, two beacon intervals away. Several counts can then go out twice even when the work runs on time. That seems to put the AP further behind a station that timed its switch from an earlier count. Could the queue and hold paths use a margin that fits the beacon interval? Best regards, Luka Gejak