From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795154013; b=eCmqg7L1kl6+OGma8zgg4FDop1xhELrHCTwoRPBJiIjS2gIChaeqFhq4BNAKiSRj5dQ9 QSJc6zly9V5rvNLyf/2BCt3jSOB9FHKGvjQYgnH2rHVOF8oFRAd9O3uZumNo1jCXOvj0s ZFySN4mxWYceFWsE/JVFQiUMPx3G78L5zf1ZCVfZu3TMT9f4r4W5FfxQ1PjvmhAhVoD9A UqKEfWBsukjvLh6dGNCuNdQRZbq3leqMeWd6xwLdjLLJ0POArzy/j2mBrRxmPSZ3yk6Xp 09rviFVmZ1Myrrnu0ZGcx1ITOOrE4GdHedkkcmFlwPvE+nEPRy3K/q6CjQm4UICEOZg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795154013; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: Reply-To:MIME-Version:Lines:X-Developer-Signature:X-Developer-Key: Content-Transfer-Encoding; bh=Gyywu4+/ylKNOwED8wAab5CjORy6dij0B12UV9LEUrE=; b=vUTBYPRZD0IdEb03B5oQ4jA6A5RN3/2j4vTidGBUX/Hnd4dbGRJS8hxLsUosQXpJvuYG /1UCkZ2UrIbkPkgJ/buEPMd6sw9aPC1/7F2qucoIAsrbug5XUXiLVM1SWkBkvClWKi+Jq 5SUC1te8wLRSI/b7pyH7PC0Xvd7bWj4jtmfDH6GoVkuoEI0C12h1z3ptb6CkDijgIV4IF cptYvRrFulKab8gweIYASKsTuOvhx5wTPqLfd+C2hpMDKxQtt0r8QtamoxgAMoiJDqa6W EN5oYgs6WmIu1cCrvOjemSzjRXBrP/mDybTKcs5IsS2QjEU1A1c9TccrC7DA6lZPJvw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="wT/jkVTu"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77CFF606A325 for ; Fri, 20 Nov 2026 05:53:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=wT/jkVTu Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6F9B1F000CA; Fri, 20 Nov 2026 05:53:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795154013; bh=Gyywu4+/ylKNOwED8wAab5CjORy6dij0B12UV9LEUrE=; h=From:To:Cc:Subject:Date:Reply-To; b=wT/jkVTumdcRgA8NCi1jQX4KmkhQNGKVNhrDXuYYXe74etWjit8shFtIxRURteoLC M0YY4tTP7gfLwaCHo5yElcDH+vkQQv1p7KtDMexwUSv+eTD4WuSCsEvzf82Dxp6PCH YF9NSbQGJUuoUz9A5puOcEp63Y2oW8bbjRhC9pe0= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2026-99570: f2fs: fix to invalidate curseg if change_curseg() fails Date: Fri, 20 Nov 2026 06:49:16 +0100 Message-ID: <2026112015-CVE-2026-99570-bf4f@gregkh> X-Mailer: git-send-email 2.56.1 Reply-To: , X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=6336; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=A8u1cjWXqbkrc01yt4MVx3fPJvOU7KEagFm94hrvJt8=; b=owGbwMvMwCRo6H6F97bub03G02pJDFn/70fHs/4oDa4580ePeXG8gIV4gaNwc0ev0mxxq0src w0nCr3piGVhEGRikBVTZPmyjefo/opDil6Gtqdh5rAygQxh4OIUgImc5mZYMF1eZGLG8fPVP4Ju mxWwTLp/Y0HVG4a5Ekapfv1p1ubvrmooFx/pUFsvYscCAA== X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit From: Greg Kroah-Hartman Description =========== In the Linux kernel, the following vulnerability has been resolved: f2fs: fix to invalidate curseg if change_curseg() fails Our consistency stress test (fsstress + fio + atomic write workers + "f2fs_io shutdown 1") triggers below kernel BUG: F2FS-fs (vdd): Stopped filesystem due to reason: 0 ------------[ cut here ]------------ kernel BUG at fs/f2fs/segment.c:3989! Oops: invalid opcode: 0000 [#1] SMP KASAN PTI Workqueue: writeback wb_workfn (flush-253:48) RIP: 0010:f2fs_allocate_data_block+0x257a/0x38e0 Call Trace: do_write_block+0x155/0xc10 f2fs_outplace_write_data+0x192/0x340 f2fs_do_write_data_page+0xc57/0x1880 f2fs_write_single_data_page+0xda9/0x15a0 f2fs_write_cache_pages+0x973/0x1f20 __f2fs_write_data_pages+0x6c4/0x1890 do_writepages+0x21e/0x560 __writeback_single_inode+0x119/0x11b0 writeback_sb_inodes+0x67d/0x17a0 wb_writeback+0x207/0x820 wb_workfn+0x128/0xc30 process_one_work+0x925/0x1600 worker_thread+0x60a/0xff0 kthread+0x35f/0x460 ret_from_fork+0x474/0x7e0 ret_from_fork_asm+0x1a/0x30 The BUG is f2fs_bug_on(sbi, curseg->next_blkoff >= BLKS_PER_SEG(sbi)) in f2fs_allocate_data_block(), next_blkoff was 512. The root cause is a race in between atomic write commit and shutdown as below: Thread A (commit atomic write) Thread B (shutdown) Thread C (writeback) - f2fs_ioc_commit_atomic_write - f2fs_commit_atomic_write - __f2fs_commit_atomic_write - __replace_atomic_write_block - f2fs_replace_block - __f2fs_replace_block - f2fs_ioc_shutdown - f2fs_do_shutdown : F2FS_GOING_DOWN_METASYNC - f2fs_sync_fs - f2fs_write_single_data_page : pass f2fs_cp_error() check - f2fs_stop_checkpoint : set CP_ERROR_FLAG - change_curseg - reset_curseg : curseg->segno = new_segno : curseg->alloc_type = SSR : curseg->next_blkoff = __next_free_blkoff() which is BLKS_PER_SEG if there is no free slot in new_segno - f2fs_get_sum_cache : return -EIO due to f2fs_cp_error() : return error w/o restoring curseg : goto out_unlock, skip restoring old segno, blkoff and alloc_type - f2fs_do_write_data_page - f2fs_outplace_write_data - do_write_block - f2fs_allocate_data_block : curseg->segno is valid : f2fs_bug_on(next_blkoff >= BLKS_PER_SEG) Since commit 86f33603f8c5 ("f2fs: handle errors of f2fs_get_meta_page_nofail"), change_curseg() can fail after the curseg has already been switched to the new segment, then the curseg is left in an inconsistent state: it points to a segment which may have no free slot, its summary block is zeroed, and the caller can not restore it. Subsequent block allocation on the curseg will trigger the BUG. Moreover, the writeback thread dies with curseg_lock, curseg_mutex and sentry_lock held, so the commit, shutdown and other I/O threads hang in D state. Since change_curseg() only fails once CP_ERROR_FLAG is set, no checkpoint will be committed afterward, let's invalidate the curseg via reset_curseg_fields() on failure, as new_curseg() does for -ENOSPC, then f2fs_allocate_data_block() will fail with -ENOSPC on the curseg instead of triggering BUG, and do_write_block() can handle the error since CP_ERROR_FLAG has been set. The Linux kernel CVE team has assigned CVE-2026-99570 to this issue. Affected and fixed versions =========================== Issue introduced in 5.10 with commit 86f33603f8c51537265ff7ac0320638fd2cbdb1b and fixed in 6.12.118 with commit 1c9ccd9eadf1707a2149c3237b85f1f82ce92702 Issue introduced in 5.10 with commit 86f33603f8c51537265ff7ac0320638fd2cbdb1b and fixed in 6.18.64 with commit c8e6c10f95643dd88e73e7daa8ceb1041631920c Issue introduced in 5.10 with commit 86f33603f8c51537265ff7ac0320638fd2cbdb1b and fixed in 7.3.5 with commit c2de116785396df236e311e7643913212fe9fe50 Issue introduced in 5.10 with commit 86f33603f8c51537265ff7ac0320638fd2cbdb1b and fixed in 7.4-rc1 with commit e74476ad8162c1facc74b74ce2d1372492df872e Issue introduced in 5.4.75 with commit df5b07f2172a159a4d9f0c280e6ecddba992ba35 Issue introduced in 5.9.5 with commit 6b67737f2dde60fbad8ddac37c8653e3c3bf0855 Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2026-99570 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: fs/f2fs/segment.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/1c9ccd9eadf1707a2149c3237b85f1f82ce92702 https://git.kernel.org/stable/c/c8e6c10f95643dd88e73e7daa8ceb1041631920c https://git.kernel.org/stable/c/c2de116785396df236e311e7643913212fe9fe50 https://git.kernel.org/stable/c/e74476ad8162c1facc74b74ce2d1372492df872e