All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>
Cc: Neill Kapron <nkapron@google.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: gadget: fsl_udc: Fix potential use-after-free during removal
Date: Fri, 20 Nov 2026 13:10:54 +0100	[thread overview]
Message-ID: <2026112015-lumber-flyer-d8f6@gregkh> (raw)
In-Reply-To: <20261118-324f82bd41-usb-gadget-1@mail.sdu.edu.cn>

On Wed, Nov 18, 2026 at 10:10:53PM +0800, Guangshuo Li wrote:
> usb_del_gadget_udc() can drop the last gadget device reference and call
> fsl_udc_release(), which frees udc_controller. The remaining remove path
> then dereferences it to release its requests, endpoints and DMA pool.
> 
> Hold a gadget device reference until this cleanup has finished.
> 
> This issue was found by our static analysis tool under development.
> 
> Fixes: eab35c4e6d95 ("usb: gadget: fsl_udc_core: let udc-core manage gadget->dev")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>
> ---
>  drivers/usb/gadget/udc/fsl_udc_core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c
> index 878d70b55530..9d9d2164c5bf 100644
> --- a/drivers/usb/gadget/udc/fsl_udc_core.c
> +++ b/drivers/usb/gadget/udc/fsl_udc_core.c
> @@ -2537,6 +2537,7 @@ static void fsl_udc_remove(struct platform_device *pdev)
>  	DECLARE_COMPLETION_ONSTACK(done);
>  
>  	udc_controller->done = &done;
> +	get_device(&udc_controller->gadget.dev);

This feels wrong, why are you needing a fake reference here?

>  	usb_del_gadget_udc(&udc_controller->gadget);

This is where it should all go away.  If not, then reorder the code
properly.


  parent reply	other threads:[~2026-11-20 12:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 14:08 [PATCH 0/2] usb: gadget: Correct cleanup ordering on failure and removal Guangshuo Li
2026-11-18 14:10 ` [PATCH 1/2] usb: gadget: fsl_udc: Fix potential use-after-free during removal Guangshuo Li
2026-11-18 14:29   ` sashiko-bot
2026-11-20 12:10   ` Greg Kroah-Hartman [this message]
2026-11-18 14:13 ` [PATCH 2/2] usb: gadget: nokia: Fix potential use-after-free on bind failure Guangshuo Li
2026-11-18 14:28   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026112015-lumber-flyer-d8f6@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=liguangshuo@mail.sdu.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nkapron@google.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.