From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org,
Md Haris Iqbal <haris.iqbal@linux.dev>,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: Re: [v4 0/3] block: delay support for error injection
Date: Fri, 20 Nov 2026 17:44:16 +0100 [thread overview]
Message-ID: <20261120164416.GA32719@lst.de> (raw)
In-Reply-To: <179501806989.17649.3138860274842922761.b4-ty@b4>
On Wed, Nov 18, 2026 at 09:07:49AM -0700, Jens Axboe wrote:
>
> On Wed, 11 Nov 2026 22:58:35 +0100, Md Haris Iqbal wrote:
> > Error injection can only fail a bio today. This adds a delay_us option so
> > that a rule can hold a bio back first, to model a slow device. The delay
> > happens above the driver, so it tests the code waiting above the block
> > layer, not the blk-mq timeout handler.
> >
> > A delayed bio is marked with a new BIO_ERROR_INJECTED flag so the rules
> > are not applied to it again, even after a split. Christoph asked on v2
> > to avoid the flag by allowing a delay only together with an error. I kept
> > delay-only rules, as a slow device that succeeds is the more useful case,
> > so the flag question is still open.
> >
> > [...]
>
> Applied, thanks!
>
Hmm. This still has rela issues as pointed out by Sashiko. I'd very
much expect a resend to address them.
prev parent reply other threads:[~2026-11-20 16:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 21:58 [v4 0/3] block: delay support for error injection Md Haris Iqbal
2026-11-11 21:58 ` [v4 1/3] block: Reject unknown status tags in error injection rules Md Haris Iqbal
2026-11-12 13:53 ` Christoph Hellwig
2026-11-11 21:58 ` [v4 2/3] block: allow error injection rules to delay bios Md Haris Iqbal
2026-11-12 13:54 ` Christoph Hellwig
2026-11-11 21:58 ` [v4 3/3] Documentation: block: document error injection delay feature Md Haris Iqbal
2026-11-12 13:54 ` Christoph Hellwig
2026-11-18 16:07 ` [v4 0/3] block: delay support for error injection Jens Axboe
2026-11-20 16:44 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120164416.GA32719@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=haris.iqbal@linux.dev \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.