All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: "Maíra Canal" <mcanal@igalia.com>
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Faith Ekstrand" <faith.ekstrand@collabora.com>,
	"Rob Herring" <robh@kernel.org>,
	"Steven Price" <steven.price@arm.com>,
	"Adrián Larumbe" <adrian.larumbe@collabora.com>,
	"Liviu Dudau" <liviu.dudau@arm.com>,
	"Akash Goel" <akash.goel@arm.com>,
	"Karunika Choo" <karunika.choo@arm.com>,
	"Lukas Zapolskas" <lukas.zapolskas@arm.com>,
	"Chris Diamand" <chris.diamand@arm.com>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Alice Ryhl" <aliceryhl@google.com>,
	kernel-dev@igalia.com, dri-devel@lists.freedesktop.org,
	rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 0/6] drm/panfrost,panthor: Refuse to export WB_MMAP BOs
Date: Fri, 20 Nov 2026 17:24:15 +0100	[thread overview]
Message-ID: <20261120172415.2aa235f0@fedora1.home> (raw)
In-Reply-To: <d2aa7dd9-367a-4b6f-8dee-3913b8e5f6a2@igalia.com>

On Fri, 20 Nov 2026 13:05:50 -0300
Maíra Canal <mcanal@igalia.com> wrote:

> Hi Boris,
> 
> On 20/11/26 06:56, Boris Brezillon wrote:
> >>
> >> Still, if you think this would be problematic, I can drop patches 3 and 6.  
> > 
> > I was about to suggest forcing uncached CPU mappings for shareable BOs
> > on systems where the GPU is IO coherent, but there's actually no way we
> > can know whether a BO will be exported on not on Panfrost (on Panthor
> > we at least have this exclusive_vm thing that gives this guarantee). So
> > there's actually no way around it, it's either going back to a "broken"
> > state (broken in the sense it's not doing what it's supposed to, but no
> > one really complained in the past) or keep this sync logic to try to do
> > our best (even if it's not entirely safe, especially if the importer
> > does crazy stuff like pretending to be UMA when it's not).
> > 
> > Sorry for not having a better answer than: it might be okay, but it
> > looks wrong. Every time I tried to understand what's expected from us
> > for this shared buffer synchronization, I ended up more confused than
> > before...
> >   
> 
> That makes two of us :)
> 
> I'm okay dropping patches 3 and 6. I decided to send them as suggested
> in our last discussion, but when I analyzed the IO-coherent case, I also
> had the impression that this could be a step back.
> 
> V3D doesn't have the IO coherent case, so I can move forward with only
> Faith's drm_gem_shmem_sync() helper and I won't need the custom
> dma_buf_ops.
> 
> If possible, could you take a look at patches 1-2 and 4-5? I'd
> appreciate it.

They look good to me.

> 
> >>
> >> The Panthor changes were tested on hardware, but Panfrost changes were
> >> only compile-tested.  
> > 
> > Could you prepare a custom gfx-ci kernel [1] so we can check that mesa
> > CI is not regressed by this change? I know none of the tests in mesa CI
> > would normally hit the removed logic, but better safe than sorry.  
> 
> Sure, I'll test the series on Mesa CI (without patches 3 and 6).
> 
> Best regards,
> - Maíra
> 


      reply	other threads:[~2026-11-20 16:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 19:38 [PATCH 0/6] drm/panfrost,panthor: Refuse to export WB_MMAP BOs Maíra Canal
2026-11-19 19:38 ` [PATCH 1/6] drm/shmem: Add a drm_gem_shmem_sync() helper Maíra Canal
2026-11-19 19:55   ` sashiko-bot
2026-11-19 19:38 ` [PATCH 2/6] drm/panfrost: Refuse to export WB_MMAP BOs Maíra Canal
2026-11-19 19:38 ` [PATCH 3/6] drm/panfrost: Drop custom dma_buf_ops Maíra Canal
2026-11-19 19:38 ` [PATCH 4/6] drm/panfrost: Use drm_gem_shmem_sync() Maíra Canal
2026-11-19 19:38 ` [PATCH 5/6] drm/panthor: Refuse to export WB_MMAP BOs Maíra Canal
2026-11-19 19:38 ` [PATCH 6/6] drm/panthor: Drop custom dma_buf_ops Maíra Canal
2026-11-20  9:56 ` [PATCH 0/6] drm/panfrost,panthor: Refuse to export WB_MMAP BOs Boris Brezillon
2026-11-20 16:05   ` Maíra Canal
2026-11-20 16:24     ` Boris Brezillon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120172415.2aa235f0@fedora1.home \
    --to=boris.brezillon@collabora.com \
    --cc=adrian.larumbe@collabora.com \
    --cc=airlied@gmail.com \
    --cc=akash.goel@arm.com \
    --cc=aliceryhl@google.com \
    --cc=chris.diamand@arm.com \
    --cc=daniel.almeida@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=faith.ekstrand@collabora.com \
    --cc=karunika.choo@arm.com \
    --cc=kernel-dev@igalia.com \
    --cc=liviu.dudau@arm.com \
    --cc=lukas.zapolskas@arm.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mcanal@igalia.com \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=steven.price@arm.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.