All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Casco <jesse.casco@gmail.com>
To: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>
Cc: Bryan O'Donoghue <bod@kernel.org>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 2/2] media: qcom: camss: Add Glymur-specific resources
Date: Fri, 20 Nov 2026 12:41:33 -0500	[thread overview]
Message-ID: <20261120174133.62863-1-jesse.casco@gmail.com> (raw)
In-Reply-To: <20261119-glymur_camss-v3-2-71ab966c41c9@oss.qualcomm.com>

On Thu, Nov 19, 2026, Nihal Kumar Gupta wrote:
> Add Glymur-specific CSIPHY resources so ports 0, 1 and 2 map to hardware
> PHY ids 0, 1 and 4. The remaining CAMSS resources continue to reuse the
> X1E80100 CAMSS resources.

Hi Nihal,

I tested this on an Asus Zenbook A16, with the series backported to 7.3
and the board's CSIPHY4 link moved to port@2. The OV02C10 on CSIPHY4 and
the HM1092 on CSIPHY0 both stream, through media-ctl and libcamera.

Tested-by: Jesse Casco <jesse.casco@gmail.com> # Asus Zenbook A16

One thing to be aware of with the reused CSID/VFE tables: on their own,
only CSID0 -> VFE0 and CSID1 -> VFE1 stream on Glymur. The lite CSIDs
get the full CSID clocks, and CAMSS assumes CSID n feeds VFE n, which
doesn't hold with three full CSIDs and two full VFEs. Both come from the
X1E80100 tables, so they're not something for this patch; I've sent
fixes here:

  https://lore.kernel.org/r/cover.1795196107.git.jesse.casco@gmail.com

I tested this patch together with those, and with them all four
CSID/VFE pairs stream as well.

Jesse

      parent reply	other threads:[~2026-11-20 17:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 15:04 [PATCH v3 0/2] media: qcom: camss: Fix Glymur CSIPHY topology Nihal Kumar Gupta
2026-11-19 15:04 ` [PATCH v3 1/2] dt-bindings: media: qcom,glymur-camss: Use linear CSI ports Nihal Kumar Gupta
2026-11-19 15:04 ` [PATCH v3 2/2] media: qcom: camss: Add Glymur-specific resources Nihal Kumar Gupta
2026-11-19 15:20   ` sashiko-bot
2026-11-20  5:10     ` Nihal Kumar Gupta
2026-11-20  8:30   ` Loic Poulain
2026-11-20 17:41   ` Jesse Casco [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120174133.62863-1-jesse.casco@gmail.com \
    --to=jesse.casco@gmail.com \
    --cc=bod@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=nihal.gupta@oss.qualcomm.com \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.