All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: linux-cxl@vger.kernel.org
Cc: dave@stgolabs.net, jic23@kernel.org, alison.schofield@intel.com,
	vishal.l.verma@intel.com
Subject: [PATCH] cxl/region: Keep a decoder staged when its auto attach fails
Date: Fri, 20 Nov 2026 11:12:28 -0700	[thread overview]
Message-ID: <20261120181228.1466310-1-dave.jiang@intel.com> (raw)

An auto region lists each arriving endpoint decoder as a target in the
AUTO_STAGED state. Once all targets are there, cxl_region_attach_position()
attaches each one port by port. Attaching at the endpoint port sets
cxld->region and moves the decoder to AUTO. If a later port fails, the
unwind clears cxld->region again, but the decoder stays in AUTO and stays
listed as a target.

When that endpoint goes away, __cxl_decoder_detach() finds no region and
calls cxl_cancel_auto_attach(), which only removes AUTO_STAGED decoders.
The freed decoder is left in the region's target list, and the next
teardown of the region reads it:

  BUG: KASAN: slab-use-after-free in __cxl_decoder_detach+0xa6/0x3b0 [cxl_core]
   cxl_decoder_detach+0x6c/0xf0 [cxl_core]
   unregister_region+0xcb/0x470 [cxl_core]
   kill_regions+0x9f/0x100 [cxl_core]

Put the decoder back in AUTO_STAGED when the unwind leaves it with no
region.

Fixes: 87805c32e6ad ("cxl/region: Fix use-after-free from auto assembly failure")
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
 drivers/cxl/core/region.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
index a048bd5c06cb..f1083976592f 100644
--- a/drivers/cxl/core/region.c
+++ b/drivers/cxl/core/region.c
@@ -1830,6 +1830,14 @@ static int cxl_region_attach_position(struct cxl_region *cxlr,
 	for (iter = cxled_to_port(cxled); !is_cxl_root(iter);
 	     iter = to_cxl_port(iter->dev.parent))
 		cxl_port_detach_region(iter, cxlr, cxled);
+
+	/*
+	 * Attaching at the endpoint port moved a staged decoder to AUTO, and
+	 * the unwind above cleared its region again. It is still listed as a
+	 * target, so keep it staged for cxl_cancel_auto_attach() to find.
+	 */
+	if (cxled->state == CXL_DECODER_STATE_AUTO && !cxled->cxld.region)
+		cxled->state = CXL_DECODER_STATE_AUTO_STAGED;
 	return rc;
 }
 

base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
-- 
2.54.0


             reply	other threads:[~2026-11-20 18:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 18:12 Dave Jiang [this message]
2026-11-20 18:39 ` [PATCH] cxl/region: Keep a decoder staged when its auto attach fails sashiko-bot
2026-11-20 20:32   ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120181228.1466310-1-dave.jiang@intel.com \
    --to=dave.jiang@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=dave@stgolabs.net \
    --cc=jic23@kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.