All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mehmet Fide <mehmet.fide@gmail.com>
To: Luka Gejak <luka.gejak@linux.dev>,
	Zong-Zhe Yang <kevin_yang@realtek.com>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
	Tzu-En Huang <tehuang@realtek.com>,
	Yan-Hsuan Chuang <yhchuang@realtek.com>,
	Kalle Valo <kvalo@kernel.org>,
	Stanislaw Gruszka <sgruszka@redhat.com>,
	Brian Norris <briannorris@chromium.org>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	mehmet.fide@screeningeagle.com
Subject: Re: [PATCH rtw-next v3 3/5] wifi: rtw88: do not drop stations when collecting them for an iteration
Date: Fri, 20 Nov 2026 19:27:30 +0100	[thread overview]
Message-ID: <20261120182730.467748-1-mehmet.fide@gmail.com> (raw)
In-Reply-To: <0f2520cdfcb86395317a39637bd0b535844e34b2@linux.dev>

Hi Luka,

> Thanks for reproducing this. I was looking at 0bdc579dbfc2, which
> already has b719e9bced93 clearing si->vif in rtw_sta_remove().

Right, my test tree was older than that commit, so what I wrote about
rtw_sta_remove() was wrong.

> Could you rebase v4 on rtw-next and keep the si->vif check in
> rtw_collect_sta_iter()? That should cover the case you reproduced.

Yes. On rtw-next 0bdc579dbfc2 with v3, the client was collected with
si->vif NULL and was gone from mac80211 after the held collection in 2
of 3 runs; in the third the watchdog did not collect it in time. With
the check in v4 it was skipped in 3 of 4 runs. In the fourth the
collection came before the client went back to AUTH, and the removal
waited for it.

Mehmet

  reply	other threads:[~2026-11-20 18:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 17:09 [PATCH rtw-next v3 0/5] wifi: rtw88: fixes around the firmware recovery Mehmet Fide
2026-11-17 17:09 ` [PATCH rtw-next v3 1/5] wifi: rtw88: free the reserved pages of an interface on " Mehmet Fide
2026-11-20 13:09   ` Luka Gejak
2026-11-20 17:01     ` Mehmet Fide
2026-11-17 17:10 ` [PATCH rtw-next v3 2/5] wifi: rtw88: report the frames purged from the TX report queue Mehmet Fide
2026-11-20 13:09   ` Luka Gejak
2026-11-20 17:02     ` Mehmet Fide
2026-11-17 17:10 ` [PATCH rtw-next v3 3/5] wifi: rtw88: do not drop stations when collecting them for an iteration Mehmet Fide
2026-11-20 13:09   ` Luka Gejak
2026-11-20 17:02     ` Mehmet Fide
2026-11-20 17:18       ` Luka Gejak
2026-11-20 18:27         ` Mehmet Fide [this message]
2026-11-17 17:10 ` [PATCH rtw-next v3 4/5] wifi: rtw88: reset the stations outside of RCU on firmware recovery Mehmet Fide
2026-11-17 17:10 ` [PATCH rtw-next v3 5/5] wifi: rtw88: clear the restart flag when the device is stopped Mehmet Fide
2026-11-17 23:15   ` Mehmet Fide
2026-11-18  0:45     ` Ping-Ke Shih
2026-11-19 14:31 ` [PATCH rtw-next v3 0/5] wifi: rtw88: fixes around the firmware recovery Luka Gejak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120182730.467748-1-mehmet.fide@gmail.com \
    --to=mehmet.fide@gmail.com \
    --cc=briannorris@chromium.org \
    --cc=kevin_yang@realtek.com \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luka.gejak@linux.dev \
    --cc=mehmet.fide@screeningeagle.com \
    --cc=pkshih@realtek.com \
    --cc=sgruszka@redhat.com \
    --cc=tehuang@realtek.com \
    --cc=yhchuang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.