From: Christoph Hellwig <hch@lst.de>
To: Heming Zhao <heming.zhao@suse.com>
Cc: joseph.qi@linux.alibaba.com, mark@fasheh.com, jlbec@evilplan.org,
ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v9 1/3] ocfs2: Add new ocfs2_map_blocks() to introduce iomap feature
Date: Fri, 20 Nov 2026 19:34:15 +0100 [thread overview]
Message-ID: <20261120183415.GA2450@lst.de> (raw)
In-Reply-To: <20261120060014.12087-2-heming.zhao@suse.com>
On Fri, Nov 20, 2026 at 02:00:11PM +0800, Heming Zhao wrote:
> As part of migrating OCFS2 DIO read/write code paths towards the modern
> and performant iomap framework, here introduces ocfs2_map_blocks() to
> replace the legacy, high-overhead buffer_head based block mapping
> routines.
Do you have numbers to antiy the high overhead? Or should this be toned
down a bit?
> In addition, OCFS2_MAP_* flags are defined to gridge OCFS2 internal block
> mapping flags with the iomap API requirements.
"gridge"?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-11-20 18:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 6:00 [RFC PATCH v9 0/3] migrate ocfs2 DIO from buffer_head to iomap Heming Zhao
2026-11-20 6:00 ` [RFC PATCH v9 1/3] ocfs2: Add new ocfs2_map_blocks() to introduce iomap feature Heming Zhao
2026-11-20 18:34 ` Christoph Hellwig [this message]
2026-11-20 6:00 ` [RFC PATCH v9 2/3] ocfs2: switch DIO read path from buffer_head to iomap Heming Zhao
2026-11-20 18:35 ` Christoph Hellwig
2026-11-20 6:00 ` [RFC PATCH v9 3/3] ocfs2: switch dio write " Heming Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120183415.GA2450@lst.de \
--to=hch@lst.de \
--cc=heming.zhao@suse.com \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.