From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.210.44 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795202677; b=ZGEYWm52k+APYdhv3kRVEN33al159NFCAsGmlGoUszPUIqsf9pjh0XGxGjMz6TJuyJmM wrKBjJYGenVD+EW32NvmqCaBtGJ7uJkHeFIqD2J7LFIV076qpGk0XV7Uxf3zmomna/9wN gTJtcGC5sfnB7smINgFM6DqtmY4ZIWrbak4oxRyiSWZdjDvadg2qMNXXGYyyQ9bFEifog 9nO7gbvrdR8Ze0jNVNTZMBJF7K9T9VAdFC9EHlelZYQDJ9SyTuR+59k5fP/3Blt4qUglH OiXEJIq8BSvJbMvLNhOATq8cH0pBTNCBPQJU5A4OQeIxnKnzMaLbGQMufuQoi7VonvA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795202677; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:From:To:Cc:Subject: Date:Message-Id:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=TzsgnDlzQFvSV3G8C43KZKQdeF3FFaampVDqZHmxwlA=; b=ovcu1YaOPVN9/hytSP5M7sAnK6noZMZEv5liZ6MaOM2dq9Sex3qjzi5jCrwgZ2M+JZbo 3dzTx5kgeAC9SNjn+vWizbRlKPEMGiEnjmTqawL3zG7mKOHckiDyCrIknBlqwTA6ia9Lk iW4+FQezRwsnvgLUIxOz7j1pXAPvWA1pvFjy9GiaKe7rZcVqI/Bd+96lxLFaLaJ5ijK8Q NOPV7q5g/03ZeIg42LwPJPYEXx1XGZ36yDs6oXgGvxbkZu7N0AsEtL2kfekaJvPeOJ1Tb 5eMwSRyWa4q7tjPympwnR5WZscJePXhbOU/T9Q01v9oI3gkSRAo8Vvix8L2FXge6fBg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=EQyWSUcs; arc=none smtp.remote-ip=209.85.210.44 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1FB0606A33A for ; Fri, 20 Nov 2026 19:24:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org A1FB0606A33A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=EQyWSUcs Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-862bb0a189aso523231a34.1 for ; Fri, 20 Nov 2026 11:24:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795202675; x=1795807475; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TzsgnDlzQFvSV3G8C43KZKQdeF3FFaampVDqZHmxwlA=; b=EQyWSUcs114e73QFSyPHEIOytxEW8a/lDJs1kqKV3Gla4dPzqRlfgDwNS1N/9c8UFr dYFlNQoPkW4yIsRWWo5m0TtxpghvtbeWQ05XxVXzdcoUip3KDznEMyMJDLP4YKb+VW/0 q70DvGgGENt7sFzn5Ycy5e4Xxtw4vdE390cGN+Fs4WX7GRXXyvsszhKNvYjzG1lTbop7 634mH1D7XFmXAaTZWORE4HK/vBI+DqHLqYDSYjTQDTRA5fE88SIdDNqEQmk1bzGpBijI j/e3gReTW+XaoPYCnL4dyF0IWqeL2Mdf9fEvvcFoDy3ERuFdt8uyEMDbddoI5cGE8Bj1 OfBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795202675; x=1795807475; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=TzsgnDlzQFvSV3G8C43KZKQdeF3FFaampVDqZHmxwlA=; b=S7juZVOwppfadQlnwAZhaDmBedSFgRx7GblJH7seAOHEcORdFcYaCChWJ2e7nHy3so D4UpTQgzTKiRatRUGKelvfLg5eCShU7O0pABW0zekLHEc8BvyZX1XDHKI0H6jDEU1EKc sqLkEvO65tSzXdmxesBJktrYq4Qdf9OROZCqZ1dvY3EvA8Z5EabVNk8U8/fiulTddxh3 /CwKcKg1ciCUjEX+fse3hlROzIRfZlm06j6Ii/M/pDntrOM9HenCl72CMZIrLcH0QocX P88SYdZxhe9FEY+ZziEqLwGnKbrtt629nVcszqCdGvJhb/p5ZiUxm8gqbPTMPY5/8JUE 78BA== X-Gm-Message-State: APuU4Z+0N++ezLqUNfOT181R6HE1tLm9l7U74UGl4MIPDT2JsU9xenlB IRL7Oe9Ub9DFlXAbMQ3khR0Mli8Rm8eLv2ghX18wR5JdRcfRmH68ic9O X-Gm-Gg: AYBFou1VseNu2mmBxRKZ2TrZ00af8FE4PN7yUMNerbaQUqEX2HUWuS6hyf73QxXx73m HyiXUe2MtkEe+TkS87XYv/jh2q2UStXlnnjh3VB61pReU43PBDYJdQ28G/uAjbRFABk6U2XJOSL /O4DUWDGf1JyEqRADZrNCk2ERrAQT3mAUFhsOPHhlgHTOwAeTRK7TMNr4w3uXLWeiN5iUsNi2JF 9vXiTx/K0XUqlRYAD1E+TD7EAD4Rf3BKi+wy74BQCD0UmZrsCTX8tMR/kBIGgmq3DJI+eEmidId rMOc3jpaOxPBoRasQ6PHgpUhkoKV4wzVrVy0NOYRqZmdagHY3tdWzFUIgG532KVMIyBkJzpkpGU Cphqjdgfzg6lajr0zvV8+3yLgtBNDYDeOGpOd4oUQNXRnHu9T87S6q7C/fUziQLPBSrosKOXj6r lWVbeZSAhWB/JG4vIjU6FTU2+o31kI8GwTe9H1yNVCYoK56AZmPLTu/VxlpnfHG5zfkPLxXVfXe reF3cIPgyFxNsEID/pSolCOo9iiAYMy9zmp1dXcyoTZFdByf9W89xrBK8SmU7lSGMlDh+1+hg1j ZLfOT/xKsDE3NeCg5seSSpL3zz9PAiu/mVqgJG4QBeNnx9hk686RPBZIjnZ1TdbjKnl/P2GlcJA xBljoxAmyAsMUoM6apRCjBW7HV3ItSxnZiBn9xcAXaHGuZ+ynsflmUBWBHNdV5Bkqhbzoww6Amw c7zCNlZHuwYV3Ktkj/Oscdvf33tQFsJOKcl9h0wOGdmLUT+mF8RqWtKreTyAb+rbR0Xioj X-Received: by 2002:a05:6808:2212:b0:55c:a67:d111 with SMTP id 5614622812f47-57a0a114703mr4595223b6e.19.1795202675222; Fri, 20 Nov 2026 11:24:35 -0800 (PST) Received: from node0.jspace.cloudfaas-pg0.wisc.cloudlab.us ([128.105.146.42]) by smtp.gmail.com with ESMTPSA id 5614622812f47-57a35e5ab03sm2854972b6e.16.2026.11.20.11.24.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2026 11:24:34 -0800 (PST) From: Mohammad Mosafer To: gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+6227549bd2c8a1ec8ba0@syzkaller.appspotmail.com, Mohammad Mosafer Subject: [PATCH v3] usb: gadget: f_fs: fix use-after-free in ffs_closed() on umount Date: Fri, 20 Nov 2026 13:24:15 -0600 Message-Id: <20261120192415.335646-1-mohsafer@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <2026112030-aflame-skid-859a@gregkh> References: <2026112030-aflame-skid-859a@gregkh> X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ffs_free_inst() releases the ffs_dev with ffs_release_dev() and only then re-acquires ffs_dev_lock to free it with _ffs_free_dev(). In between, the dev is still linked on the ffs_devices list while already marked unmounted, so a concurrent mount(2) of functionfs finds it by name in ffs_acquire_dev() and links a fresh ffs_data to the doomed dev (ffs_data->private_data = dev). _ffs_free_dev() then kfrees the dev, and when that mount is torn down, ffs_closed() dereferences the stale ffs->private_data: BUG: KASAN: slab-use-after-free in ffs_data_clear+0x438/0x530 Write of size 1 at addr ffff88810594664a by task repro/116 ffs_data_clear+0x438/0x530 ffs_fs_kill_sb+0x7b/0x510 deactivate_locked_super+0xa9/0x200 cleanup_mnt+0x255/0x380 ... reached via umount(2) Freed by task 112: kfree+0x127/0x3b0 ffs_free_inst+0x10c/0x1a0 usb_put_function_instance+0x8a/0xc0 configfs_rmdir+0x773/0x9c0 Allocated by task 113: ffs_alloc_inst+0x109/0x360 function_make+0x138/0x330 configfs_mkdir+0x48b/0x1090 Hold ffs_dev_lock across the release and the free so that a released dev is never findable, splitting ffs_release_dev() into a lock-assuming _ffs_release_dev() (matching the _ffs_* convention in this file) and enforcing its caller-holds-the-lock contract with lockdep_assert_held(). For the same reason, re-read ffs->private_data under ffs_dev_lock in ffs_data_put(): the argument read there was unlocked, so a concurrent ffs_free_inst() could unlink and free the dev while the putter waited on the mutex, and the subsequent ffs_release_dev() would dereference the freed dev. The now unreached ffs_release_dev() wrapper is dropped; its remaining callers use _ffs_release_dev() with the lock held. The race was reproduced with a multi-threaded harness racing configfs mkdir/rmdir of the ffs instance against mount/umount of functionfs on a KASAN kernel: the unpatched kernel reports the use-after-free reliably (2/2 runs), the patched kernel survives an extended soak with identical churn (2/2 runs clean). Reported-by: syzbot+6227549bd2c8a1ec8ba0@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=6227549bd2c8a1ec8ba0 Fixes: 5920cda627688c ("usb: gadget: FunctionFS: convert to new function interface with backward compatibility") Signed-off-by: Mohammad Mosafer --- Hi Greg, Right - the comment duplicated the commit message, so it is gone. The lock contract is now enforced with lockdep_assert_held(&ffs_lock) instead of the comment; ffs_lock is the mutex behind the ffs_dev_lock()/ffs_dev_unlock() wrappers. Changes in v3: - Drop the explanatory comment in ffs_free_inst(); it duplicated the commit message (Greg KH). - Enforce the caller-holds-the-lock contract of _ffs_release_dev() with lockdep_assert_held(&ffs_lock) instead of a comment (Greg KH). Link to v2: https://lore.kernel.org/r/20261006214940.158352-1-mohsafer@gmail.com Changes in v2: - Re-read ffs->private_data under ffs_dev_lock in ffs_data_put(): the unlocked argument read raced with a concurrent ffs_free_inst() freeing the dev while the putter waited on ffs_dev_lock (flagged by the Sashiko review bot). - Drop the now-unused ffs_release_dev() wrapper. drivers/usb/gadget/function/f_fs.c | 19 +++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index c64a268e98a4..3aab4c28e310 100644 --- a/drivers/usb/gadget/function/f_fs.c +++ b/drivers/usb/gadget/function/f_fs.c @@ -288,7 +288,7 @@ static struct ffs_dev *_ffs_find_dev(const char *name); static struct ffs_dev *_ffs_alloc_dev(void); static void _ffs_free_dev(struct ffs_dev *dev); static int ffs_acquire_dev(const char *dev_name, struct ffs_data *ffs_data); -static void ffs_release_dev(struct ffs_dev *ffs_dev); +static void _ffs_release_dev(struct ffs_dev *ffs_dev); static int ffs_ready(struct ffs_data *ffs); static void ffs_closed(struct ffs_data *ffs); static void ffs_reset_work(struct work_struct *work); @@ -2231,7 +2231,14 @@ static void ffs_data_put(struct ffs_data *ffs) if (refcount_dec_and_test(&ffs->ref)) { pr_info("%s(): freeing\n", __func__); ffs_data_clear(ffs); - ffs_release_dev(ffs->private_data); + /* + * ffs->private_data must be re-read under ffs_dev_lock: + * a concurrent ffs_free_inst() may have NULLed it and + * freed the dev it pointed to. + */ + ffs_dev_lock(); + _ffs_release_dev(ffs->private_data); + ffs_dev_unlock(); BUG_ON(waitqueue_active(&ffs->ev.waitq) || swait_active(&ffs->ep0req_completion.wait) || waitqueue_active(&ffs->wait)); @@ -4147,8 +4154,8 @@ static void ffs_free_inst(struct usb_function_instance *f) struct f_fs_opts *opts; opts = to_f_fs_opts(f); - ffs_release_dev(opts->dev); ffs_dev_lock(); + _ffs_release_dev(opts->dev); _ffs_free_dev(opts->dev); ffs_dev_unlock(); kfree(opts); @@ -4363,9 +4370,9 @@ static int ffs_acquire_dev(const char *dev_name, struct ffs_data *ffs_data) return ret; } -static void ffs_release_dev(struct ffs_dev *ffs_dev) +static void _ffs_release_dev(struct ffs_dev *ffs_dev) { - ffs_dev_lock(); + lockdep_assert_held(&ffs_lock); if (ffs_dev && ffs_dev->mounted) { ffs_dev->mounted = false; @@ -4377,8 +4384,6 @@ static void ffs_release_dev(struct ffs_dev *ffs_dev) if (ffs_dev->ffs_release_dev_callback) ffs_dev->ffs_release_dev_callback(ffs_dev); } - - ffs_dev_unlock(); } static int ffs_ready(struct ffs_data *ffs) -- 2.34.1