All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [PATCH linus-next] platform profile: Use PLATFORM_PROFILE in the asus drivers
Date: Fri, 20 Nov 2026 14:51:34 -0500	[thread overview]
Message-ID: <20261120195135.613480-1-sashal@kernel.org> (raw)
In-Reply-To: <20261120181059.GypXyRIq-lkp@intel.com>

Commit 699041135f75 ("platform profile: Extract the core from ACPI") in
the pm tree renames ACPI_PLATFORM_PROFILE to PLATFORM_PROFILE. Two users
from other trees still have the old name:

commit ef696e89f836 ("platform/asus: Move ASUS platform drivers out of
drivers/platform/x86") in the pdx86 tree moves ASUS_WMI with "select
ACPI_PLATFORM_PROFILE", so a config where nothing else selects
PLATFORM_PROFILE fails to link:

  ERROR: modpost: drivers/platform/asus/asus-wmi.ko: symbol 'devm_platform_profile_register' undefined!
  ERROR: modpost: drivers/platform/asus/asus-wmi.ko: symbol 'platform_profile_cycle' undefined!

commit d220bf485598 ("HID: asus: Cycle the platform profile from the
Zenbook Duo profile key") in the hid tree checks
IS_REACHABLE(CONFIG_ACPI_PLATFORM_PROFILE), which is now always false,
so the profile key does nothing.

Fixes: fc099de5a4ac ("Merge branch 'pm-next' into all-next")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/20261120181059.GypXyRIq-lkp@intel.com/
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/hid/hid-asus.c        | 4 ++--
 drivers/platform/asus/Kconfig | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index dcb3d50f9288e..aca4ab6ab2391 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -438,7 +438,7 @@ static int asus_platform_profile_cycle(struct asus_drvdata *drvdata)
 	struct asus_worker *worker = drvdata->worker;
 	struct asus_work_action *action, *pending;
 
-	if (!IS_REACHABLE(CONFIG_ACPI_PLATFORM_PROFILE))
+	if (!IS_REACHABLE(CONFIG_PLATFORM_PROFILE))
 		return 0;
 
 	guard(spinlock_irqsave)(&worker->lock);
@@ -870,7 +870,7 @@ static void asus_work(struct work_struct *work)
 		asus_kbd_wmi_fan(worker->hdev, &action->data.fan_hid_data);
 		break;
 	case PLATFORM_PROFILE_CYCLE:
-		if (!IS_REACHABLE(CONFIG_ACPI_PLATFORM_PROFILE))
+		if (!IS_REACHABLE(CONFIG_PLATFORM_PROFILE))
 			break;
 		ret = platform_profile_cycle();
 		if (ret)
diff --git a/drivers/platform/asus/Kconfig b/drivers/platform/asus/Kconfig
index 4b79957f045fc..0219418ce3523 100644
--- a/drivers/platform/asus/Kconfig
+++ b/drivers/platform/asus/Kconfig
@@ -127,7 +127,7 @@ config ASUS_WMI
 	select INPUT_SPARSEKMAP
 	select LEDS_CLASS
 	select NEW_LEDS
-	select ACPI_PLATFORM_PROFILE
+	select PLATFORM_PROFILE
 	help
 	  Say Y here if you have a WMI aware Asus laptop (like Eee PCs or new
 	  Asus Notebooks).
-- 
2.53.0


      reply	other threads:[~2026-11-20 19:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 17:13 [sashal-linus-next:linus-next 29/46] ERROR: modpost: drivers/platform/asus/asus-wmi.ko: symbol 'platform_profile_cycle' undefined! kernel test robot
2026-11-20 19:51 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120195135.613480-1-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.