All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Aring <aahringo@redhat.com>
To: teigland@redhat.com
Cc: aahringo@redhat.com, gfs2@lists.linux.dev
Subject: [PATCHv2 RESEND v7.4-rc3 0/5] dlm: various fixes
Date: Fri, 20 Nov 2026 15:00:35 -0500	[thread overview]
Message-ID: <20261120200040.257152-1-aahringo@redhat.com> (raw)

Hi David,

This patch series contains mostly AI-assisted fixes and cleanups
across the DLM subsystem:

 - Add missing length checks for oversized inner DLM messages,
   this prevents potential buffer overruns or malformed packet
   handling.

 - Enforce RSB assignment before using LKBs, this ensures LKBs
   cannot exist in lkbxa without an associated RSB set. It
   resolves an issue with concurrent DLM user requests.

 - Prevent DLM_ASSERT() on canceled pending requests, this fixes an
   assertion failure triggered when a initial request is canceled and
   recovery is triggered during this state.

 - Fix lockspace node memory leak during release, this resolves a leak
   involving delayed member removal during active lockspace releasing
   members. Active releasing members will not run recovery so the delayed
   cleanup of removed of members will never occur.

 - Fixes a case where the reconnect mechanism gets stuck if a socket error
   occurs while the socket send buffer is full. This was found by the
   netdev-bot (sashik AI bot) [3]. I tested it with tcpkill again, and
   everything still seems to run fine. To test this specific case, I used
   netem to slow down networking so the socket buffer would fill up while
   running tcpkill to trigger socket errors.

Ensuring that LKBs always have an RSB assigned should also reduce the
likelihood of subtle bugs elsewhere in the codebase where an RSB presence
check might be missing.

There is a pending sysfs fix [0] that conflicts with [1]. The fix for
[1] does not go through the dlm tree so [0] is delayed until [1] is
available.

- Alex

[0] https://lore.kernel.org/gfs2/20261019184849.24422-1-sanan.hasanou@gmail.com/
[1] https://lore.kernel.org/gfs2/20261027223847.652884-6-irogers@google.com/
[2] https://lore.kernel.org/gfs2/179090395863.434549.3668493667259120759@kernel.org/

changes since v2:
 - add patch to fix the socket hang on send buffer limitation
 - drop the Assisted-by tags

Alexander Aring (2):
  dlm: fix socket hang on send buffer limitation with socket error
  dlm: fix memory leak on active leaving member

Ameer Hamza (1):
  dlm: don't set RSB_MASTER_UNCERTAIN on rsb with no master

Jérémy Jean (1):
  dlm: reject wrapped messages with oversized inner lengths

Yogesh Gaur (1):
  dlm: don't publish a lkb in ls_lkbxa before it has an rsb

 fs/dlm/config.c   |  9 +++++
 fs/dlm/lock.c     | 98 ++++++++++++++++++++++++++++++++---------------
 fs/dlm/lowcomms.c | 47 ++++++++++++++++-------
 fs/dlm/midcomms.c |  8 ++++
 4 files changed, 118 insertions(+), 44 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-11-20 20:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 20:00 Alexander Aring [this message]
2026-11-20 20:00 ` [PATCHv2 RESEND v7.4-rc3 1/5] dlm: fix socket hang on send buffer limitation with socket error Alexander Aring
2026-11-20 20:00 ` [PATCHv2 RESEND v7.4-rc3 2/5] dlm: reject wrapped messages with oversized inner lengths Alexander Aring
2026-11-20 20:00 ` [PATCHv2 RESEND v7.4-rc3 3/5] dlm: don't publish a lkb in ls_lkbxa before it has an rsb Alexander Aring
2026-11-20 20:00 ` [PATCHv2 RESEND v7.4-rc3 4/5] dlm: don't set RSB_MASTER_UNCERTAIN on rsb with no master Alexander Aring
2026-11-20 20:00 ` [PATCHv2 RESEND v7.4-rc3 5/5] dlm: fix memory leak on active leaving member Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120200040.257152-1-aahringo@redhat.com \
    --to=aahringo@redhat.com \
    --cc=gfs2@lists.linux.dev \
    --cc=teigland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.