From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.198 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795204858; b=xX8XTQYvIsr0xjlD2uV4wtWSXEFXDFdPqpdnKr6asgVhIVxLVCJJEW0PTClczvEHY+mt 1hE4igpris9dPYAJ096KgSGSj+bVg6wCzU6/0PgNds9mfavbj84zHAAPiKH1oWJ6IvyvP JTJ+Lh9JYm76AupZNkHyPP10/lLD8tUlvBniMnwHxcHwxbAON5MSiFnq//aMsHF3K2F4H y2dGnpgtGH6+JKokwarWrjetfwrOXORty4AehURCu+WbBxvuJz4l1HROtdHlS3EW7Eaxc IYUgJIx74PkT4iJe66tHIE5rx2OjWE4uxBZHqe0NUJQXRVFPvjUIDSLOTQt81tcEtyQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795204858; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Received:Date:In-Reply-To:Mime-Version: References:X-Mailer:Message-ID:Subject:From:To:Cc:Content-Type; bh=v6MACD1sBfgK5beVMe+EiTqIGqdXAEDg9pQGTzuk0wA=; b=eieYQwH7pYqYupnFnm/Ur/ycd6vUMB8XPbD1lgOUzRZEV2GxNPCuYx7EcsT/7DUlfILv ieBQ5lMW6FJpdEjVaTYg72kYTSQS86SvaK4/C7gpVVq6qmVGYUsYWU3IVm2R/kmcI7CSw RCYpAAQ2j3RDs0x8nk2B/qPgm5yg32Xw2q+w+DTfgOn9IlElGkHyegvUhhRXxptxW+7rU HYvn5vMlR0AazoFSZht7rcLHWQPEUZaGSg1XZYaTPo1DhFuG7EN9ELCJ4V4CaNxFCCJQE tBYRdyWA9CQGgxeiaADU2tSrgnyWkuHUCoLtuTDcwkQs70ixcuLzqEaWQImOu8mHfEg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--elkin.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=mvSCHHSQ; arc=none smtp.remote-ip=74.125.82.198 Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFFB3606A336 for ; Fri, 20 Nov 2026 20:00:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BFFB3606A336 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--elkin.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=mvSCHHSQ Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-30bcb065bfdso1377522eec.0 for ; Fri, 20 Nov 2026 12:00:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1795204856; x=1795809656; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=v6MACD1sBfgK5beVMe+EiTqIGqdXAEDg9pQGTzuk0wA=; b=mvSCHHSQ4+VLK8nz9MRPufP779dzfiskHFZtamiDap/o42aSqIsdtvN9mRH4XxHtSQ 9hf8WmY2fmWDaAmVIm7izW5QxCiW5zL2XW0hY8Bvk7jXlffbl65bhqZZAhmPHuaeMfdz ZmqhkYFKPC6IC6ul4qY+0GB8Pegzj+ko9fmlbgow/HCF4st9gYKaylBhW5XBDlmWJO3Y MTH00PadJhETHD6o3WvBglhF0obII1hSsJgtSgpXBuixEJ2K5lfC+3el3sEdoMZu+ond i+BtsZ5m0C73muqqTx+jRGqfYQkmMiy4v6scA8BHhM8VZ/wUjYn9yKjNOZkRj9JVrbl/ YmbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795204856; x=1795809656; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=v6MACD1sBfgK5beVMe+EiTqIGqdXAEDg9pQGTzuk0wA=; b=Cfiw/2HabnDwEFh9CkHgqm3D5MDeoqMXOGrvUyn10W1ND+KFwo3MarXvpMeH+zk0hB SNBmoOF9iCeK71bSiGpqAUM4KJ5C6YxbzTmP0KBxXIht9CCX9d11U5WjayPaltRVaWgN CiTsImVWgmP7xHElQO8O6LJy44k42DOhia94pEL/ug+rekFTq/Xyai0wNR2RUv1N7tM5 lUiDwqXcR8lHLLthXfkwUZmnbZDvzqzgcB+KsofiYKoo2QIcrewUUCYz17aAoor7YWnz aA3P4+U2CxKJXfUYBKqWozyMH60rKGTMaBJoQ73q/3/qNNEBd/LRlx0z0rAutQ4uTb2L WwUg== X-Gm-Message-State: APuU4Z8KdeX2pCZUS/Oy216jtPvqXW/Q09bcsVF2NeWFhForKKKl8Xbt /n5bTwG5REM/UfUDCHKc0P/bIjwtPIppPmV8VVN++exUEjfBdC2lGLFs3v3Wq4mJmH5gxfvdQ+o lsQ== X-Received: from dycc14.prod.google.com ([2002:a05:693c:60ce:b0:380:e54c:744c]) (user=elkin job=prod-delivery.src-stubby-dispatcher) by 2002:a05:693c:880d:10b0:36b:fca0:80b3 with SMTP id 5a478bee46e88-3856fd5d0f0mr4234213eec.22.1795204855427; Fri, 20 Nov 2026 12:00:55 -0800 (PST) Date: Fri, 20 Nov 2026 20:00:47 +0000 In-Reply-To: X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: X-Mailer: git-send-email 2.56.1.750.gf70dc682cf-goog Message-ID: <20261120200047.2917735-1-elkin@google.com> Subject: Re: [PATCH] serial: 8250_exar: check IS_ERR() on __xr17v35x_register_gpio() From: Elkin Cruz To: Greg Kroah-Hartman , Jiri Slaby Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, sashiko-reviews@lists.linux.dev, llvm@lists.linux.dev, irogers@google.com Content-Type: text/plain; charset="UTF-8" On Fri, Nov 20, 2026 at 07:40:04PM +0000, sashiko-bot@kernel.org wrote: Please ignore this patch. > The error-pointer dereference in xr17v35x_unregister_gpio() mentioned in > the commit message was already fixed by 0353b5196588 ("serial: 8250_exar: > check priv->gpio properly"), which checks !IS_ERR_OR_NULL(priv->gpio). > > Previously, GPIO platform-device registration failure was non-fatal so the > card's UART ports would still be registered. Propagating PTR_ERR(pdev) from > xr17v35x_register_gpio() and iot2040_register_gpio() causes > pci_xr17v35x_setup() to fail on port 0, which breaks out of the port setup > loop in exar_pci_probe() at i == 0 and leaves the card with zero UART ports > registered while exar_pci_probe() still returns 0: Sashiko is right here - 0353b5196588 already fixed the unbind bug in xr17v35x_unregister_gpio(), and returning an error from register_gpio() would abort UART port setup in exar_pci_probe(). Thanks, Elkin