All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Dinaburg <artem@trailofbits.com>
To: stable@vger.kernel.org
Cc: deller@gmx.de, dri-devel@lists.freedesktop.org,
	linux-fbdev@vger.kernel.org, mlbnkm1@gmail.com, simona@ffwll.ch
Subject: [6.18.y] Please pick three fbdev mode-sysfs fixes
Date: Fri, 20 Nov 2026 15:10:03 -0500	[thread overview]
Message-ID: <20261120201003.42046-1-artem@trailofbits.com> (raw)

Hi,

Please pick these fbdev fixes for 6.18.y, in this order:

  d15d51fb26e830af58f3f21964f1c09c239077ea (CVE-2026-80580)
  ("fbdev: bound mode sysfs output to the sysfs buffer")
  95e647d2a5304a8fd11f1ba3c8502de700650131 (CVE-2026-80579)
  ("fbdev: clear fb_info->mode before deleting a videomode")
  061db6b7a910b8378f3b2df64f8c0a3ddc6e85f2 (CVE-2026-80785)
  ("fbdev: serialize mode sysfs access with lock_fb_info()")

They bound the modes output to the sysfs buffer, clear fb_info->mode
before its modelist entry is freed, and serialize the mode sysfs readers
and writers with modelist replacement in store_modes().

The fixes were tagged "Cc: stable@vger.kernel.org # v7.1+" and are so
far only in 7.1.10/7.1.11 and in mainline since 7.2. The affected code
is older: the CVE records list all three bugs as present since 2.6.12,
and 6.18.64 has the same unlocked show_mode(), show_modes() and
store_mode() paths. If the v7.1+ limit was intentional, please let me
know and disregard this request.

The prerequisite, upstream commit 6f611e5e5f33 ("fbdev: Wrap
user-invoked calls to fb_set_var() in helper"), has been in 6.18.y since
6.18.57. All three fixes apply unchanged, in order, on 6.18.64, and no
patch currently in queue-6.18 touches the same files. 6.12.y and older
stable series lack these fixes as well; this request covers only 6.18.y.

Compiled drivers/video/fbdev/core/fbmem.o and fbsysfs.o on 6.18.64 from
a cumulative x86_64 tree using allmodconfig. No kernel boot or runtime
test was performed.

An LLM was used to check applicability and stable-queue history and to
draft this request; I reviewed the result.

Thanks,
Artem Dinaburg

             reply	other threads:[~2026-11-20 20:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 20:10 Artem Dinaburg [this message]
2026-11-21 15:27 ` [6.18.y] Please pick three fbdev mode-sysfs fixes Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120201003.42046-1-artem@trailofbits.com \
    --to=artem@trailofbits.com \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=mlbnkm1@gmail.com \
    --cc=simona@ffwll.ch \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.