All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Ondřej Jirman" <megi@xff.cz>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Al Viro <viro@zeniv.linux.org.uk>, Sam Day <me@samcday.com>,
	Michael Bommarito <michael.bommarito@gmail.com>,
	fanggeng <fanggeng@lixiang.com>,
	Mateusz Guzik <mjguzik@gmail.com>, Kees Cook <kees@kernel.org>
Subject: Re: [PATCH] usb: gadget: f_fs: Init reset_work at alloc to avoid kill_sb WARN
Date: Fri, 20 Nov 2026 11:21:57 +0100	[thread overview]
Message-ID: <2026112025-linguist-refusing-439b@gregkh> (raw)
In-Reply-To: <20260725120838.2263579-1-megi@xff.cz>

On Sat, Jul 25, 2026 at 02:08:34PM +0200, Ondřej Jirman wrote:
> From: Ondrej Jirman <megi@xff.cz>
> 
> ffs_data is zero-allocated and reset_work is only INIT_WORK'd on the
> FFS_DEACTIVATED path in set_alt/disable, which the normal flow never
> takes. ffs_fs_kill_sb() then cancel_work_sync()s it unconditionally,
> tripping the WARN_ON(!work->func) in __flush_work() with a NULL func.

How does that happen?  What triggers it?

> 
> Initialize reset_work once in ffs_data_new() and drop the redundant
> lazy INIT_WORK calls.
> 
> Signed-off-by: Ondrej Jirman <megi@xff.cz>

No fixes tag?  No cc: stable?

What found this issue?  How was it tested?

thanks,

greg k-h

  reply	other threads:[~2026-11-20 10:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-25 12:08 [PATCH] usb: gadget: f_fs: Init reset_work at alloc to avoid kill_sb WARN Ondřej Jirman
2026-11-20 10:21 ` Greg Kroah-Hartman [this message]
2026-11-20 18:06   ` Ondřej Jirman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026112025-linguist-refusing-439b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=fanggeng@lixiang.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=me@samcday.com \
    --cc=megi@xff.cz \
    --cc=michael.bommarito@gmail.com \
    --cc=mjguzik@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.