All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Aviv Levinson <levinson.aviv@gmail.com>
Cc: dtwlin@gmail.com, johan@kernel.org, elder@kernel.org,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: greybus: uart: convert idr to xarray
Date: Fri, 20 Nov 2026 08:05:52 +0100	[thread overview]
Message-ID: <2026112027-demotion-nature-db29@gregkh> (raw)
In-Reply-To: <20261112160546.27094-1-levinson.aviv@gmail.com>

On Thu, Nov 12, 2026 at 06:05:46PM +0200, Aviv Levinson wrote:
> The legacy IDR API is deprecated in favor of the modern XArray API.
> Convert the tty_minors IDR to an XArray.
> 
> To prevent locking the entire gb_tty object while loading the minor,
> switch IDR to XArray and use the internal XArray's spinlock (xa_lock).
> To respect TTY encapsulation, use tty_port_get()
> instead of direct kref_get_unless_zero().
> 
> Signed-off-by: Aviv Levinson <levinson.aviv@gmail.com>
> ---
>  drivers/staging/greybus/uart.c | 27 ++++++++++++---------------
>  1 file changed, 12 insertions(+), 15 deletions(-)

Again, this is not a needed change, and odds are one you didn't actually
test with the hardware, so I can't take it for now, sorry.

greg k-h

      reply	other threads:[~2026-11-20  7:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 18:23 [PATCH] staging: greybus: uart: replace IDR with XArray Aviv Levinson
2026-11-12 12:37 ` Greg KH
2026-11-12 16:05   ` Aviv Levinson
2026-11-12 16:05   ` [PATCH v2] staging: greybus: uart: convert idr to xarray Aviv Levinson
2026-11-20  7:05     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026112027-demotion-nature-db29@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dtwlin@gmail.com \
    --cc=elder@kernel.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=levinson.aviv@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.