From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: hyunjungg <hj351016@gmail.com>
Cc: Neill Kapron <nkapron@google.com>,
Ruslan Bilovol <ruslan.bilovol@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v3] usb: gadget: f_uac1_legacy: disable OUT ep and drain work on teardown
Date: Fri, 20 Nov 2026 12:17:03 +0100 [thread overview]
Message-ID: <2026112044-darling-stained-ab13@gregkh> (raw)
In-Reply-To: <20261108133532.532633-1-hj351016@gmail.com>
On Sun, Nov 08, 2026 at 10:35:32PM +0900, hyunjungg wrote:
> From: Hyunjung Ko <hj351016@gmail.com>
>
> f_uac1_legacy enables the OUT endpoint in f_audio_set_alt() and queues
> usb_requests whose completion handler f_audio_complete() dereferences the
> f_audio (req->context) and audio->out_ep, and which schedules
> audio->playback_work. However f_audio_disable() is empty and nothing
> disables the endpoint or drains the work on teardown, so:
>
> - f_audio_complete() can run after kfree(audio) (the UDC gives back
> pending requests on the still-enabled endpoint during unbind), using
> freed memory -- a use-after-free; and
> - a playback_work still pending runs f_audio_playback_work() against the
> freed f_audio -- a second use-after-free.
>
> Disable the OUT endpoint in f_audio_disable(): the UDC then gives back the
> outstanding requests, so f_audio_complete() stops touching @audio and no
> new playback_work is queued. f_audio_disable() runs in atomic context
> (reset_config() holds cdev->lock), and usb_ep_disable() is safe there.
>
> Drain the work from f_audio_free() instead, where sleeping is allowed:
> cancel_work_sync(&audio->playback_work) before gaudio_cleanup() tears down
> audio->card (which f_audio_playback_work() -> u_audio_playback()
> dereferences) and before kfree(audio). The endpoint is already disabled by
> the time f_audio_disable() has run, so the work cannot be re-queued and
> cancel_work_sync() is sufficient.
>
> Found by static analysis and an automated reviewer; the playback_work
> use-after-free was reproduced with KASAN under dummy_hcd (slab-use-after-
> free in u_audio_playback() from f_audio_playback_work() after
> f_audio_free(); a delay was added to the streaming path to make the
> schedule-vs-free race deterministic). The out_ep/f_audio_complete
> use-after-free is established by code inspection.
>
> Fixes: c6994e6f067c ("USB: gadget: add USB Audio Gadget driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Hyunjung Ko <hj351016@gmail.com>
> ---
> v3: Fix the v2 regressions found in review:
> - Do NOT cancel_work_sync() in f_audio_disable(): that callback runs in
> atomic context (reset_config() under cdev->lock), so the sleeping
> cancel would be a sleep-in-atomic. Only usb_ep_disable() (atomic-safe)
> stays in f_audio_disable(); the work is drained from f_audio_free().
> - Drop the play_queue/copy_buf drain added in v2: audio->copy_buf can
> alias a buffer already on play_queue (f_audio_set_alt altset 0 queues
> it without clearing the pointer) and can hold ERR_PTR(-ENOMEM), so
> freeing it there double-freed / dereferenced an error pointer. That
> buffer-leak + copy_buf aliasing is a separate pre-existing issue and
> is left for a dedicated fix.
> - Correct the Fixes: tag to the original driver commit c6994e6f067c.
>
> v2: https://lore.kernel.org/linux-usb/20261108122645.421721-1-hj351016@gmail.com/
> drivers/usb/gadget/function/f_uac1_legacy.c | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_uac1_legacy.c b/drivers/usb/gadget/function/f_uac1_legacy.c
> index 7c8d60c..c07f323 100644
> --- a/drivers/usb/gadget/function/f_uac1_legacy.c
> +++ b/drivers/usb/gadget/function/f_uac1_legacy.c
> @@ -697,7 +697,17 @@ static int f_audio_get_alt(struct usb_function *f, unsigned intf)
>
> static void f_audio_disable(struct usb_function *f)
> {
> - return;
> + struct f_audio *audio = func_to_audio(f);
> +
> + /*
> + * Disable the OUT endpoint: the UDC gives back any outstanding
> + * usb_requests, so f_audio_complete() stops dereferencing @audio and
> + * no further playback_work is queued. This callback runs in atomic
> + * context (reset_config() holds cdev->lock), so it must not sleep;
> + * the work is drained from f_audio_free() instead.
> + */
Why is this comment needed?
LLMs love to write comments, be sensible instead.
thanks,
greg k-h
prev parent reply other threads:[~2026-11-20 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 13:35 [PATCH v3] usb: gadget: f_uac1_legacy: disable OUT ep and drain work on teardown hyunjungg
2026-11-08 13:58 ` sashiko-bot
2026-11-20 11:17 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026112044-darling-stained-ab13@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hj351016@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nkapron@google.com \
--cc=ruslan.bilovol@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.