All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: fabricioakio@gmail.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: u_serial: Dequeue the console request only when queued
Date: Fri, 20 Nov 2026 14:56:06 +0100	[thread overview]
Message-ID: <2026112047-tying-pep-8093@gregkh> (raw)
In-Reply-To: <20260928-u-serial-console-dequeue-v1-1-b44d68585632@gmail.com>

On Mon, Sep 28, 2026 at 03:18:18PM -0300, Fabricio Akio via B4 Relay wrote:
> From: Fabricio Akio <fabricioakio@gmail.com>
> 
> gs_console_disconnect() dequeues the console request even when it is
> idle, which dwc3 reports as "request ... was not queued" on every
> disconnect. Dequeue it only while req->length marks it as queued.
> 
> Signed-off-by: Fabricio Akio <fabricioakio@gmail.com>
> ---
> Tested on a Motorola Moto X4 (XT1900-6, SDM630) with the sdm660-mainline
> 7.2.3 tree and the gadget serial console in use: "request ... was not
> queued to ep3in" is logged on every system suspend without this patch,
> and not over three consecutive cycles with it. The path where the
> request is still queued at disconnect was not exercised. Applies
> unchanged to next-20260928.
> ---
>  drivers/usb/gadget/function/u_serial.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Please address the issues found here:
	https://sashiko.dev/#/patchset/20260928-u-serial-console-dequeue-v1-1-b44d68585632@gmail.com

      reply	other threads:[~2026-11-20 13:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 18:18 [PATCH] usb: gadget: u_serial: Dequeue the console request only when queued Fabricio Akio via B4 Relay
2026-09-28 18:18 ` Fabricio Akio
2026-11-20 13:56 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026112047-tying-pep-8093@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=fabricioakio@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.