All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Mak <bmak@nvidia.com>
To: "Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Kurt Borja" <kuurtb@gmail.com>,
	"Stuart Hayes" <stuart.w.hayes@gmail.com>,
	"Matthew Garrett" <mjg59@srcf.ucam.org>,
	"Pali Rohár" <pali@kernel.org>,
	"Lyndon Sanche" <lsanche@lyndeno.ca>,
	"Armin Wolf" <W_Armin@gmx.de>,
	"Prasanth Ksr" <prasanth.ksr@dell.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Brian Mak" <bmak@nvidia.com>
Subject: [PATCH 8/8] platform: dell: pc: Don't load if SMBIOS calls are non-functional
Date: Fri, 20 Nov 2026 16:05:54 -0800	[thread overview]
Message-ID: <20261121000556.173028-9-bmak@nvidia.com> (raw)
In-Reply-To: <20261121000556.173028-1-bmak@nvidia.com>

dell-pc relies on the SMBIOS calling interface for thermal modes. On
platforms where the interface returns all-zero buffers, dell-pc reads
no current thermal mode, and fails with "platform_profile probe failed".

Don't load dell-pc on these platforms.

Signed-off-by: Brian Mak <bmak@nvidia.com>
---
 drivers/platform/dell/dell-pc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/platform/dell/dell-pc.c b/drivers/platform/dell/dell-pc.c
index becdd9aaef29..4f361ec01b29 100644
--- a/drivers/platform/dell/dell-pc.c
+++ b/drivers/platform/dell/dell-pc.c
@@ -282,6 +282,9 @@ static int __init dell_init(void)
 	if (!dmi_check_system(dell_device_table))
 		return -ENODEV;
 
+	if (!dell_smbios_calls_functional())
+		return -ENODEV;
+
 	dell_pc_fdev = faux_device_create("dell-pc", NULL, &dell_pc_faux_ops);
 	if (!dell_pc_fdev)
 		return -ENODEV;
-- 
2.53.0


      parent reply	other threads:[~2026-11-21  0:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21  0:05 [PATCH 0/8] platform: dell: Move out of x86 and support Dell XPS 16 Creator Edition Brian Mak
2026-11-21  0:05 ` [PATCH 1/8] platform/x86: dell: Make uart-backlight x86 only Brian Mak
2026-11-21  1:36   ` Randy Dunlap
2026-11-21  1:36     ` Randy Dunlap
2026-11-21  0:05 ` [PATCH 2/8] platform: dell: Move out of x86 directory Brian Mak
2026-11-21 10:05   ` kernel test robot
2026-11-21  0:05 ` [PATCH 3/8] MAINTAINERS: Add Dell platform drivers entry Brian Mak
2026-11-21  0:05 ` [PATCH 4/8] platform: dell: Allow DELL_LAPTOP to be arch-independent Brian Mak
2026-11-21  0:48   ` Pali Rohár
2026-11-21  1:38   ` Randy Dunlap
2026-11-21  0:05 ` [PATCH 5/8] platform: dell: smbios-wmi: Fix probe on RTX Spark Brian Mak
2026-11-21  0:05 ` [PATCH 6/8] platform: dell: smbios: Add quirk for non-functional calling interface Brian Mak
2026-11-21  0:38   ` Pali Rohár
2026-11-21  0:45     ` Brian Mak
2026-11-21  0:51       ` Pali Rohár
2026-11-21  0:05 ` [PATCH 7/8] platform: dell: laptop: Don't load if SMBIOS calls are non-functional Brian Mak
2026-11-21  0:05 ` Brian Mak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121000556.173028-9-bmak@nvidia.com \
    --to=bmak@nvidia.com \
    --cc=Dell.Client.Kernel@dell.com \
    --cc=W_Armin@gmx.de \
    --cc=corbet@lwn.net \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=kuurtb@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lsanche@lyndeno.ca \
    --cc=mjg59@srcf.ucam.org \
    --cc=pali@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=prasanth.ksr@dell.com \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=stuart.w.hayes@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.