From: Christoph Hellwig <hch@lst.de>
To: sashiko-reviews@lists.linux.dev
Cc: Andrey Albershteyn <aalbersh@kernel.org>,
Eric Biggers <ebiggers@kernel.org>,
Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>,
fsverity <fsverity@lists.linux.dev>,
david@fromorbit.com
Subject: Re: [PATCH v19 05/15] xfs: handle fsverity I/O in write/read path
Date: Sat, 21 Nov 2026 01:26:02 +0100 [thread overview]
Message-ID: <20261121002602.GB13395@lst.de> (raw)
In-Reply-To: <sashiko-outbox-225565@kernel.org>
On Fri, Nov 20, 2026 at 04:27:02PM +0000, sashiko-bot@kernel.org wrote:
> [Severity: High]
> Will iomap_writeback_folio() skip dirty fs-verity metadata folios before
> xfs_map_blocks() can set IOMAP_F_FSVERITY?
>
> xfs_vm_writepages() zero-initializes wpc.ctx.iomap.flags (and
> xc.ctx.iomap.flags on zoned filesystems), and iomap_writeback_folio()
> calls iomap_writeback_handle_eof() before ->writeback_range() invokes
> xfs_map_blocks(). When a dirty fs-verity folio past i_size is reached,
> wpc->iomap.flags still lacks IOMAP_F_FSVERITY, so
> iomap_writeback_handle_eof() returns false and the folio is skipped with
> its dirty bit cleared and its delalloc extent unconverted.
>
> Also, in xfs_zoned_map_blocks(), the non-hole path calls
> xfs_iomap_set_anon_write(), which overwrites wpc->iomap.flags with
> IOMAP_F_ANON_WRITE | IOMAP_F_DIRTY and drops IOMAP_F_FSVERITY.
Yeah. This was kinda why I wondered if an inode flag would do
better for this.
> > +xfs_iomap_is_fsverity_metadata(
> > + struct xfs_inode *ip,
> > + loff_t offset)
> > +{
> > + return offset >= xfs_fsverity_metadata_offset(ip) &&
> > + (fsverity_is_building(VFS_I(ip)) || fsverity_active(VFS_I(ip)));
> > +}
>
> [Severity: High]
> Does calling fsverity_is_building() here break the build? Neither
> linux/fsverity.h nor xfs_verity.h declares or defines
> fsverity_is_building(), so compiling fs/xfs/xfs_iomap.c fails with an
> implicit function declaration error.
It might make sense to include the core fs/fsverity patches in the series
so that human and less humane reviewers have the full context.
next prev parent reply other threads:[~2026-11-21 0:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 15:57 [PATCH v19 00/15] fs-verity support for XFS with post EOF merkle tree Andrey Albershteyn
2026-11-20 15:57 ` [PATCH v19 01/15] xfs: introduce fsverity on-disk changes Andrey Albershteyn
2026-11-20 16:26 ` sashiko-bot
2026-11-21 0:23 ` Christoph Hellwig
2026-11-20 15:57 ` [PATCH v19 02/15] xfs: don't allow to enable DAX on fs-verity sealed inode Andrey Albershteyn
2026-11-20 15:57 ` [PATCH v19 03/15] xfs: disable direct read path for fs-verity files Andrey Albershteyn
2026-11-20 15:57 ` [PATCH v19 04/15] xfs: don't report dio_mem_align and dio_offset_align for fsverity files Andrey Albershteyn
2026-11-20 15:57 ` [PATCH v19 05/15] xfs: handle fsverity I/O in write/read path Andrey Albershteyn
2026-11-20 16:27 ` sashiko-bot
2026-11-21 0:26 ` Christoph Hellwig [this message]
2026-11-20 15:57 ` [PATCH v19 06/15] xfs: use read ioend for fsverity data verification Andrey Albershteyn
2026-11-20 15:57 ` [PATCH v19 07/15] xfs: add XFS_BMAPI_UNWRITTEN to unmap unwritten extents in __xfs_bunmapi() Andrey Albershteyn
2026-11-21 0:26 ` Christoph Hellwig
2026-11-20 15:57 ` [PATCH v19 08/15] xfs: don't remove written extents past EOF on fsverity inodes Andrey Albershteyn
2026-11-20 16:21 ` sashiko-bot
2026-11-21 0:32 ` Christoph Hellwig
2026-11-20 15:57 ` [PATCH v19 09/15] xfs: add fs-verity support Andrey Albershteyn
2026-11-20 16:51 ` sashiko-bot
2026-11-20 15:57 ` [PATCH v19 10/15] xfs: initialize fs-verity on file open Andrey Albershteyn
2026-11-20 15:57 ` [PATCH v19 11/15] xfs: add fs-verity ioctls Andrey Albershteyn
2026-11-20 16:19 ` sashiko-bot
2026-11-20 15:57 ` [PATCH v19 12/15] xfs: advertise fs-verity being available on filesystem Andrey Albershteyn
2026-11-20 15:57 ` [PATCH v19 13/15] xfs: check and repair the verity inode flag state Andrey Albershteyn
2026-11-20 16:28 ` sashiko-bot
2026-11-20 15:57 ` [PATCH v19 14/15] xfs: introduce health state for corrupted fsverity metadata Andrey Albershteyn
2026-11-20 16:36 ` sashiko-bot
2026-11-20 15:57 ` [PATCH v19 15/15] xfs: enable ro-compat fs-verity flag Andrey Albershteyn
2026-11-20 16:38 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261121002602.GB13395@lst.de \
--to=hch@lst.de \
--cc=aalbersh@kernel.org \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=ebiggers@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.