From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7DAE606A320 for ; Sat, 21 Nov 2026 09:18:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=aK9k4WMA Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 011B310E242; Sat, 21 Nov 2026 09:18:53 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 414FD10E242; Sat, 21 Nov 2026 09:18:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1795252728; x=1826788728; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=47CbEugCOkJMog57P3DdjF+OExylaCYntrmSkY4FJf0=; b=aK9k4WMAVB4QMs9v6JXO/0bMYC45nnM+/vzdSm/+o4sGThpvd9QvDkZf w4g0A2l3w9NNkre460Pyo3SVc/qXIku3lnJFCcC3wBi5aZfl0SLMPuEQz K+WCZY+c2QocHOawtMEhsVBAZokxwl1bh1rsIFKMzOJPqlayuvMSwIoRy ht/xETvErQqNWlQPJnShYrKqkTor1OZBYpeS3p4dzyRNKiPNs8EDw9UNK rtYNDFBJgfRikAWWUQ/tsppLe3QmqwZQj3uEpAizBSSMA5fftE0i5yqz0 IvYQ4L1IbgHqY7axqyCgeV7NHK8iyFBrH9e6RSm/rwh6qsuAxw8gSlPj3 Q==; X-CSE-ConnectionGUID: tbZikrRDSIi3ZBdHDBZA4A== X-CSE-MsgGUID: Q4Wl+MA6QRGRuyiSNtzWQg== X-IronPort-AV: E=McAfee;i="6800,10657,11972"; a="4040164" X-IronPort-AV: E=Sophos;i="6.27,224,1787036400"; d="scan'208";a="4040164" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2026 01:18:47 -0800 X-CSE-ConnectionGUID: ouH4SdJXQoKblpB6P+umJw== X-CSE-MsgGUID: duZ8/5SUQyeDqQSHDtdGhQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,224,1787036400"; d="scan'208";a="11462979" Received: from cyp05.fm.intel.com ([10.36.55.41]) by fmviesa010.fm.intel.com with ESMTP; 21 Nov 2026 01:18:47 -0800 From: Shuicheng Lin To: dri-devel@lists.freedesktop.org Cc: Shuicheng Lin , intel-xe@lists.freedesktop.org, Natalie Vock , Arun Pravin , Matthew Auld , Matthew Brost , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , linux-kernel@vger.kernel.org Subject: [PATCH] drm/ttm: Don't warn on oversized page directory allocations Date: Sat, 21 Nov 2026 01:18:13 -0800 Message-ID: <20261121091815.1436090-2-shuicheng.lin@intel.com> X-Mailer: git-send-email 2.43.0 X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "dri-devel" X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 The page directory size in ttm_tt_alloc_page_directory() and ttm_dma_tt_alloc_page_directory() comes from the user-supplied BO size. kvmalloc() warns on requests above INT_MAX unless __GFP_NOWARN is set, so userspace can trigger a WARN (or a panic with panic_on_warn) by creating a huge BO, e.g. a 1 TiB sysmem BO on xe with DEFER_BACKING: WARNING: mm/slub.c:7144 at __kvmalloc_node_noprof+0x665/0x810 Call Trace: ttm_tt_init+0x1e0/0x2b0 xe_ttm_tt_create+0x2cf/0x4b0 [xe] ttm_tt_create+0x17c/0x310 ... xe_gem_create_ioctl+0x70f/0x12b0 [xe] The failure is already handled and the ioctl returns -ENOMEM, so pass __GFP_NOWARN to both allocations. Fixes: 7661809d493b ("mm: don't allow oversized kvmalloc() calls") Signed-off-by: Shuicheng Lin --- drivers/gpu/drm/ttm/ttm_tt.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index b645a1818184..5dc9d3795b04 100644 --- a/drivers/gpu/drm/ttm/ttm_tt.c +++ b/drivers/gpu/drm/ttm/ttm_tt.c @@ -117,7 +117,8 @@ EXPORT_SYMBOL_FOR_TESTS_ONLY(ttm_tt_create); */ static int ttm_tt_alloc_page_directory(struct ttm_tt *ttm) { - ttm->pages = kvcalloc(ttm->num_pages, sizeof(void*), GFP_KERNEL); + ttm->pages = kvcalloc(ttm->num_pages, sizeof(void *), + GFP_KERNEL | __GFP_NOWARN); if (!ttm->pages) return -ENOMEM; @@ -127,7 +128,8 @@ static int ttm_tt_alloc_page_directory(struct ttm_tt *ttm) static int ttm_dma_tt_alloc_page_directory(struct ttm_tt *ttm) { ttm->pages = kvcalloc(ttm->num_pages, sizeof(*ttm->pages) + - sizeof(*ttm->dma_address), GFP_KERNEL); + sizeof(*ttm->dma_address), + GFP_KERNEL | __GFP_NOWARN); if (!ttm->pages) return -ENOMEM; base-commit: 61df0d1929e7e99d38404a1be02c461a8f6a3f5a -- 2.43.0