From: Yixun Lan <dlan@kernel.org>
To: E Shattow <e@freeshell.de>
Cc: u-boot@lists.u-boot-project.org,
Lukasz Majewski <lukma@nabladev.com>,
Tom Rini <trini@konsulko.com>,
Junhui Liu <junhui.liu@pigmoral.tech>
Subject: Re: [PATCH v2] clk: spacemit: k3: reduce clock tree for SPL build
Date: Sat, 21 Nov 2026 09:58:17 +0000 [thread overview]
Message-ID: <20261121095817-GKA203137@kernel.org> (raw)
In-Reply-To: <530bc058-178e-4181-920c-b5319e48ada2@freeshell.de>
Hi E Shattow,
On 00:03 Sat 21 Nov , E Shattow wrote:
> On 11/20/26 19:05, Yixun Lan wrote:
> > Hi All,
> >
> >
> > On 11:07 Tue 03 Nov , Yixun Lan wrote:
> >> Due to SPL image running in a memory space constraint SRAM environment,
> >> so reduce the whole clock tree a bit to make it fit for final runtime
> >> requirement, only a subset clock tree is registered, which includes UART,
> >> SDHCI, I2C (TWSI), and their PLL/MPMU/APMU/APBC ancestors; while the
> >> full clock tree is retained in non-SPL build.
> >>
> > I'd like to drop or postpone this patch for now, the goal was trying
> > to reduce the code size of clock driver especially for SPL phase which
> > both target for persistent NOR flash storage and run-time memory consumption
> > space.. but tested on actual board found, there is enough space.. so
> > leave it as is for now
> >
>
> For persistent NOR flash storage support the FSL SPI driver needs
> updated in u-boot from mainline Linux. There's some lesser improvements
> to it in u-boot now that probably need discussed and sent to Linux as well.
>
I'm not aware there is specific SPI changes needed for SPI NOR flash..
> >
> >> Where surviving SPL CCU definitions reference parent clocks outside
> >> that subset tree, it will use "clock-dummy" as name of clock parent to
> >> ensure the framework still successfully resolves the parent clock lookup.
> >>
> > For above using "clock-dummy" clock, will send a separate patch for it,
> > so will fix the unresolved clock tree warning..
> >
> >> Signed-off-by: Yixun Lan <dlan@kernel.org>
> >> ---
> >> Changes in v2:
> >> - add gpio clock
> >> - fix tswi8 clock
> >> - enable sdh0 clock
> >> - Link to v1: https://patch.msgid.link/20260825-01-k3-clock-reset-support-v1-6-c430253e759c@kernel.org
> >> ---
> >> drivers/clk/spacemit/clk-k3.c | 209 ++++++++++++++++++++++++++++++++++++++----
> >> 1 file changed, 190 insertions(+), 19 deletions(-)
> >>
> >
> > ...
> >
>
> FYI not including clock tree reduction or parent dummy clock
No need above patches, so that's fine
> substitution, for what I understand the "bsp-spi" reduced vendor SPL
> build I document at:
>
> https://lore.kernel.org/u-boot/20261029003327.1890979-1-e@freeshell.de/
>
> ...fails to detect SPI NOR flash when K3 SoC has ran in BootROM SPL
> Loader "UART" mode; It is successful when ran in BootROM SPL Loader
> "USB" (fastboot compatible) mode. There is some peripheral setup done by
> the BootROM code in one or the other that persists through and should be
> considered when testing. I would guess that re-sync of the source code
> in u-boot for FSL SPI driver from mainline Linux, and port of the
> SpacemiT K1/K3 specific FSL SPI glue code, would be a next step to
> getting working SPI flash from within u-boot main app u-boot.itb
>
Could you check if below patch will fix your problem? which I've just
sent out
https://patch.msgid.link/20261120-05-fsl-qspi-clock-v1-1-bacea4ebd54b@kernel.org
> What SPL build are you using for testing?
>
I have some local patches those not have significant changes, and about
to send them out soon..
--
Yixun Lan (dlan)
prev parent reply other threads:[~2026-11-21 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 11:07 [PATCH v2] clk: spacemit: k3: reduce clock tree for SPL build Yixun Lan
2026-11-21 3:05 ` Yixun Lan
2026-11-21 8:03 ` E Shattow
2026-11-21 9:58 ` Yixun Lan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261121095817-GKA203137@kernel.org \
--to=dlan@kernel.org \
--cc=e@freeshell.de \
--cc=junhui.liu@pigmoral.tech \
--cc=lukma@nabladev.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.