From: Greg KH <gregkh@linuxfoundation.org>
To: Tanuj Sharma <ertanuj96@gmail.com>
Cc: ntfs3@lists.linux.dev, almaz.alexandrovich@paragon-software.com,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] ntfs3: fix out-of-bounds write in do_action() bitmap operations
Date: Sat, 21 Nov 2026 13:01:54 +0100 [thread overview]
Message-ID: <2026112132-spending-smoking-5e7d@gregkh> (raw)
In-Reply-To: <6b0186b4.6dbf942f.174087.451e@mx.google.com>
On Sat, Nov 21, 2026 at 03:55:32AM -0800, Tanuj Sharma wrote:
> In do_action(), when replaying log records for ATTR_ALLOC attributes,
> the buffer is allocated based on bytes_per_index (typically 4096 bytes,
> kmalloc-4k) but bitmap operation bounds checking uses lco -- a larger
> value derived from lcns_follow << cluster_bits (typically 8192).
>
> This allows SetBitsInNonresidentBitMap and ClearBitsInNonresidentBitMap
> opcodes to write past the allocated buffer into the adjacent slab object
> when processing crafted NTFS images with malicious $LogFile records.
>
> The bounds check compares against lco (the full LCN extent size) but
> should compare against the actual buffer capacity. For ATTR_ALLOC, the
> buffer is only bytes_per_index bytes, allocated here:
>
> if (attr->type == ATTR_ALLOC) {
> t32 = le32_to_cpu(oe->bytes_per_index);
> if (bytes < t32)
> bytes = t32;
> }
> buffer_le = kmalloc(bytes, GFP_NOFS);
>
> But the bounds check uses the larger lco:
>
> if (cbo + (off + 7) / 8 > lco || ...)
>
> With bytes_per_index=4096 and lco=8192, any bitmap_off >= 32768
> (byte offset 4096) passes the lco check but writes past the buffer.
>
> Fix this by computing the bounds limit as the minimum of the buffer
> extent (cbo + bytes_per_index) and the LCN extent (lco). This ensures
> bitmap operations cannot exceed either the allocated buffer or the
> on-disk extent, and also prevents a crafted bytes_per_index larger
> than lco from weakening the existing check.
>
> Found by code audit and confirmed with a crafted NTFS image that
> triggers the OOB write on mount.
>
> Cc: stable@vger.kernel.org
> Fixes: b46acd6a6a62 ("fs/ntfs3: Add NTFS journal")
> Signed-off-by: Tanuj Sharma <ertanuj96@gmail.com>
> ---
> fs/ntfs3/fslog.c | 20 ++++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c
> index 1879d04e3cd05..85590f56587c2 100644
> --- a/fs/ntfs3/fslog.c
> +++ b/fs/ntfs3/fslog.c
> @@ -3751,10 +3751,16 @@ static int do_action(struct ntfs_log *log, struct OPEN_ATTR_ENRTY *oe,
> off = le32_to_cpu(((struct BITMAP_RANGE *)data)->bitmap_off);
> bits = le32_to_cpu(((struct BITMAP_RANGE *)data)->bits);
>
> - if (cbo + (off + 7) / 8 > lco ||
> - cbo + ((off + bits + 7) / 8) > lco) {
> + {
> + u64 bmp_limit = attr->type == ATTR_ALLOC ?
> + min(cbo + (u64)le32_to_cpu(oe->bytes_per_index), lco) :
> + lco;
> +
> + if (cbo + (off + 7) / 8 > bmp_limit ||
> + cbo + ((off + bits + 7) / 8) > bmp_limit) {
> goto dirty_vol;
> }
> + }
>
> ntfs_bitmap_set_le(Add2Ptr(buffer_le, roff), off, bits);
> a_dirty = true;
> @@ -3764,10 +3770,16 @@ static int do_action(struct ntfs_log *log, struct OPEN_ATTR_ENRTY *oe,
> off = le32_to_cpu(((struct BITMAP_RANGE *)data)->bitmap_off);
> bits = le32_to_cpu(((struct BITMAP_RANGE *)data)->bits);
>
> - if (cbo + (off + 7) / 8 > lco ||
> - cbo + ((off + bits + 7) / 8) > lco) {
> + {
> + u64 bmp_limit = attr->type == ATTR_ALLOC ?
> + min(cbo + (u64)le32_to_cpu(oe->bytes_per_index), lco) :
> + lco;
> +
> + if (cbo + (off + 7) / 8 > bmp_limit ||
> + cbo + ((off + bits + 7) / 8) > bmp_limit) {
> goto dirty_vol;
> }
> + }
That's obviously a coding style issue, please fix.
Also, no v2 information below the --- line?
thanks,
greg k-h
next prev parent reply other threads:[~2026-11-21 12:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 2:22 [PATCH] ntfs3: fix out-of-bounds write in do_action() bitmap operations Tanuj Sharma
2026-11-21 9:43 ` Greg KH
2026-11-21 11:55 ` [PATCH v2] " Tanuj Sharma
2026-11-21 12:01 ` Greg KH [this message]
2026-11-21 12:24 ` [PATCH v3] " Tanuj Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026112132-spending-smoking-5e7d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=ertanuj96@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.