From: Martin KaFai Lau <martin.lau@linux.dev>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
Eulgyu Kim <eulgyukim@snu.ac.kr>
Subject: Re: [PATCH v2 bpf] bpf: Free reuseport cBPF prog after RCU grace period.
Date: Fri, 8 May 2026 13:42:33 -0700 [thread overview]
Message-ID: <20265820377.lHsx.martin.lau@linux.dev> (raw)
In-Reply-To: <20260426012647.3233119-1-kuniyu@google.com>
On Sun, Apr 26, 2026 at 01:26:43AM +0000, Kuniyuki Iwashima wrote:
> +static void sk_reuseport_prog_free_rcu(struct rcu_head *rcu)
> +{
> + struct bpf_prog_aux *aux = container_of(rcu, struct bpf_prog_aux, rcu);
> + struct bpf_prog *prog = aux->prog;
> +
> + bpf_release_orig_filter(prog);
> + bpf_prog_free(prog);
afaict, __bpf_prog_release() is the canonical way to free a classic prog.
How about __bpf_prog_release(aux->prog)?
If it makes sense to you, I can make the change before applying.
next prev parent reply other threads:[~2026-05-08 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 1:26 [PATCH v2 bpf] bpf: Free reuseport cBPF prog after RCU grace period Kuniyuki Iwashima
2026-05-08 20:42 ` Martin KaFai Lau [this message]
2026-05-08 22:13 ` Kuniyuki Iwashima
2026-05-08 20:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20265820377.lHsx.martin.lau@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=eulgyukim@snu.ac.kr \
--cc=kuni1840@gmail.com \
--cc=kuniyu@google.com \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.