From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] examples/power: add baseline mode to PMD power
Date: Sat, 10 Jul 2021 08:43:55 +0200 [thread overview]
Message-ID: <2029301.lu3ZZSHYa3@thomas> (raw)
In-Reply-To: <a69465da-c0c6-3c8f-cd72-6dbe1a1f7146@intel.com>
23/06/2021 16:14, Burakov, Anatoly:
> On 23-Jun-21 1:09 PM, David Hunt wrote:
> > On 23/6/2021 11:14 AM, Burakov, Anatoly wrote:
> >> On 22-Jun-21 3:07 PM, David Hunt wrote:
> >>> The PMD Power Management scheme currently has 3 modes,
> >>> scale, monitor and pause. However, it would be nice to
> >>> have a baseline mode for easy comparison of power savings
> >>> with and without these modes.
> >>>
> >>> This patch adds a 'baseline' mode were the pmd power
> >>> management is not enabled. Use --pmg-mgmt=baseline.
> >>>
> >>> Signed-off-by: David Hunt <david.hunt@intel.com>
> >>>
> >>> ---
> >>> - if (app_mode == APP_MODE_PMD_MGMT) {
> >>> + if ((app_mode == APP_MODE_PMD_MGMT) &&
> >>> + (baseline_enabled == false)) {
> >>
> >> Nitpicking, !baseline_enabled
> >>
> > Thanks, Anatoly. I don't feel a re-spin is needed for this, but I'll
> > take this format into consideration for future patches, OK?
>
> Yep, i'm fine either way. Maybe someone can fix it on apply :)
Applied with the change.
prev parent reply other threads:[~2021-07-10 6:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 11:30 [dpdk-dev] [PATCH v1] examples/power: add baseline mode to PMD power David Hunt
2021-06-02 11:14 ` Burakov, Anatoly
2021-06-22 14:07 ` [dpdk-dev] [PATCH v2] " David Hunt
2021-06-23 10:14 ` Burakov, Anatoly
2021-06-23 12:09 ` David Hunt
2021-06-23 14:14 ` Burakov, Anatoly
2021-07-10 6:43 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2029301.lu3ZZSHYa3@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.