RE: [PATCH v3 06/24] mpi3mr: add support of event handling part-1

[Kashyap Desai <kashyap.desai@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 636 bytes --]

> > @@ -1924,6 +1931,12 @@ static int mpi3mr_alloc_reply_sense_bufs(struct
> mpi3mr_ioc *mrioc)
> >  	if (!mrioc->init_cmds.reply)
> >  		goto out_failed;
> >
> > +	for (i = 0; i < MPI3MR_NUM_DEVRMCMD; i++) {
> > +		mrioc->dev_rmhs_cmds[i].reply = kzalloc(mrioc-
> >facts.reply_sz,
> > +		    GFP_KERNEL);
> > +		if (!mrioc->dev_rmhs_cmds[i].reply)
> > +			goto out_failed;
> > +	}
>
> As I wrote in V2, the above allocation chunk ends up in twice in
> mpi3mr_alloc_reply_sense_bufs. Please fix it (probably in 13/24).

I missed this.  Both allocation and free part of "dev_rmhs_cmds " end up in
twice. I will fix it in 13/24.

Kashyap

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]