From: David Howells <dhowells@redhat.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: dhowells@redhat.com, jmorris@namei.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, jirislaby@gmail.com,
Serge Hallyn <serue@us.ibm.com>
Subject: Re: [PATCH 1/1] cred: fix memory leak
Date: Wed, 06 Jan 2010 17:06:43 +0000 [thread overview]
Message-ID: <20320.1262797603@redhat.com> (raw)
In-Reply-To: <1262797265-26557-1-git-send-email-jslaby@suse.cz>
Jiri Slaby <jslaby@suse.cz> wrote:
> Stanse found a memory leak in prepare_exec_creds. tgcred is not
> freed/assigned on all paths. Fix that.
>
> I.e. unifdef tgcred and add kfree(tgcred); as it is initialized to
> NULL already.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: David Howells <dhowells@redhat.com>
> Cc: James Morris <jmorris@namei.org>
> Cc: Serge Hallyn <serue@us.ibm.com>
Acked-by: David Howells <dhowells@redhat.com>
next prev parent reply other threads:[~2010-01-06 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 17:01 [PATCH 1/1] cred: fix memory leak Jiri Slaby
2010-01-06 17:06 ` David Howells [this message]
2010-01-06 17:25 ` Serge E. Hallyn
2010-01-06 17:31 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20320.1262797603@redhat.com \
--to=dhowells@redhat.com \
--cc=jirislaby@gmail.com \
--cc=jmorris@namei.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.