From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:39042 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbeIFOdz (ORCPT ); Thu, 6 Sep 2018 10:33:55 -0400 From: Laurent Pinchart To: Simon Horman Cc: Geert Uytterhoeven , Laurent Pinchart , Linux-Renesas Subject: Re: [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support Date: Thu, 06 Sep 2018 12:59:20 +0300 Message-ID: <2032675.nQfVxexfDx@avalon> In-Reply-To: <20180906094231.eccvg2asl7kgotu2@verge.net.au> References: <20180819194455.25096-1-laurent.pinchart+renesas@ideasonboard.com> <20180906094231.eccvg2asl7kgotu2@verge.net.au> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hello, On Thursday, 6 September 2018 12:42:32 EEST Simon Horman wrote: > On Thu, Aug 23, 2018 at 11:58:54AM +0200, Geert Uytterhoeven wrote: > > On Sun, Aug 19, 2018 at 9:44 PM Laurent Pinchart wrote: > >> The Salvator-X and XS boards have a 4 lines DIP switch and 3 push > >> buttons connected to SoC GPIOs, meant to be used as general-purpose test > >> keys. Add a corresponding node in DT, mapping (semi-randomly) the DIP > >> switch to keys 1-4 and the push buttons to keys A-C. > >> > >> Signed-off-by: Laurent Pinchart > >> > > > > Given GP6_1[123] are not just wired to the 3 push buttons, but also to 3 > > LEDs, I wonder if we shouldn't postpone that part until Linux can handle > > GPIOs connected to both? > > Laurent, any thoughts on that? Right now the GPIOs are not wired in DT, and we're thus without a way to interface to both LEDs and push buttons. While I agree that an ideal solution would be to support both, I think that moving from nothing to support for push buttons would be a step forward already. -- Regards, Laurent Pinchart