From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY Date: Thu, 22 Jun 2017 17:28:21 +0300 Message-ID: <2032791.zG0HDMl4PB@avalon> References: <3690108.zYIGBGnVBz@avalon> <1941ce39-1a8e-5e16-bdc2-71d988ee00d6@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 34CEB6E044 for ; Thu, 22 Jun 2017 14:27:44 +0000 (UTC) In-Reply-To: <1941ce39-1a8e-5e16-bdc2-71d988ee00d6@synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jose Abreu Cc: Laurent Pinchart , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Carlos Palminha , Kieran Bingham List-Id: dri-devel@lists.freedesktop.org SGkgSm9zZSwKCk9uIFR1ZXNkYXkgMTMgSnVuIDIwMTcgMTU6MTE6MjcgSm9zZSBBYnJldSB3cm90 ZToKPiBIaSBMYXVyZW50LAo+IAo+IFNvcnJ5IGZvciB0aGUgbGF0ZSByZXBseSEKCk5vIHdvcnJp ZXMuCgo+IE9uIDEwLTA2LTIwMTcgMDk6NTAsIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPiBP biBGcmlkYXkgMDkgSnVuIDIwMTcgMTM6NTM6MTIgSm9zZSBBYnJldSB3cm90ZToKPiA+PiBPbiAw OS0wNi0yMDE3IDEyOjA0LCBKb3NlIEFicmV1IHdyb3RlOgo+ID4+PiBDdXJyZW50bHkgSERNSSAy LjAgUEhZcyBkbyBub3QgaGF2ZSBhIGRlZmF1bHQgY29uZmlndXJhdGlvbiBmdW5jdGlvbi4KPiA+ Pj4gCj4gPj4+IEFzIHRoZXNlIFBIWXMgaGF2ZSB0aGUgc2FtZSByZWdpc3RlciBsYXlvdXQgYXMg dGhlIDNEIFBIWXMgd2UgY2FuCj4gPj4+IHNhZmVseSB1c2UgdGhlIGRlZmF1bHQgY29uZmlndXJh dGlvbiBmdW5jdGlvbi4KPiA+PiAKPiA+PiBJIG1heSBoYXZlIGJlZW4gYSBsaXR0bGUgdG8gZmFz dCBhcnJpdmluZyBhdCB0aGlzIGNvbmNsdXNpb24uIEkKPiA+PiBtZWFuIG1vc3Qgb2YgdGhlIHJl Z2lzdGVycyBtYXRjaCBidXQgaW4gdGhlIGNvbmZpZ3VyYXRpb24KPiA+PiBmdW5jdGlvbiB0aGVy ZSBhcmUgcmVnaXN0ZXJzIHRoYXQgZG8gbm90IG1hdGNoLiBEaWQgeW91IGFjdHVhbGx5Cj4gPj4g dGVzdCB0aGlzIGNvbmZpZ3VyYXRpb24gZnVuY3Rpb24gd2l0aCBhbiBIRE1JIDIuMCBwaHk/IEFu ZCBkaWQKPiA+PiB5b3UgdGVzdCB3aXRoIGRpZmZlcmVudCB2aWRlbyBtb2Rlcz8gRnJvbSBteSBl eHBlcmllbmNlIHRoZSBwaHkKPiA+PiBtYXkgYmUgd3JvbmdseSBjb25maWd1cmVkIGFuZCBzb21l dGltZXMgd29yayBhbnl3YXkuCj4gPj4gCj4gPj4gRG8gcGxlYXNlIHJldGVzdCB3aXRoIGFzIG1h bnkgdmlkZW8gbW9kZXMgYXMgeW91IGNhbiBhbmQgZ2l2ZSBtZQo+ID4+IHlvdXIgcGh5IElEIChy ZWFkIGZyb20gY29udHJvbGxlciBjb25maWcgcmVnIEhETUlfQ09ORklHMl9JRCkuCj4gPiAKPiA+ IFRoZSBSZW5lc2FzIFItQ2FyIEdlbjMgSERNSSBQSFkgcmVwb3J0cyBhbiBEV0MgSERNSSAyLjAg VFggUEhZIElELCBidXQgaGFzCj4gPiBhIGNvbmZpZ3VyYXRpb24gZnVuY3Rpb24gKHJjYXJfaGRt aV9waHlfY29uZmlndXJlKCkgaW4KPiA+IGRyaXZlcnMvZ3B1L2RybS9yY2FyLSBkdS9yY2FyX2R3 X2hkbWkuYykgdGhhdCBkb2Vzbid0IG1hdGNoCj4gPiBoZG1pX3BoeV9jb25maWd1cmVfZHdjX2hk bWlfM2RfdHgoKS4gRnJvbSB0aGUgaW5mb3JtYXRpb24gSSBoYXZlIGJlZW4KPiA+IGdpdmVuIHRo ZSBsYXlvdXQgb2YgdGhlIGNvbmZpZ3VyYXRpb24gcmVnaXN0ZXJzIGhhdmVuJ3QgYmVlbiBjaGFu Z2VkIGJ5Cj4gPiBSZW5lc2FzLiBJIGtub3cgd2UndmUgYnJpZWZseSBkaXNjdXNzZWQgdGhpcyBp biB0aGUgcGFzdCwgYnV0IEknZAo+ID4gYXBwcmVjaWF0ZSBpZiB5b3UgY291bGQgaGF2ZSBhIHNl Y29uZCBsb29rIGFuZCB0ZWxsIG1lIHdoYXQgeW91IHRoaW5rLgo+IAo+IFl1cCwgeW91cnMgc2Vl bXMgY29ycmVjdC4gVGhvdWdoIGF0IHRoZSB0aW1lIHlvdSBzdWJtaXR0ZWQgSQo+IGZvdW5kIGl0 IG9kZCB0aGF0IG9ubHkgMyByZWdpc3RlcnMgbmVlZGVkIHRvIGJlIHdyaXR0ZW4gd2hpbHN0Cj4g Zm9yIEhETUkgMi4wIHBoeXMgSSBoYXZlIGhlcmUgNiByZWdpc3RlcnMsIGJ1dCB5b3Ugc2FpZCBp dCBpcwo+IHdvcmtpbmcgc28gSSB0aG91Z2ggeW91ciBwaHkgd2FzIGRpZmZlcmVudCAuLi4KPiAK PiBFdmVuIHNvLCBvbmUgdGhpbmcgSSB3b3VsZCBsaWtlIHRvIGtub3cgaXMgd2hhdCB3YXMgdGhl IG1heAo+IHJlc29sdXRpb24geW91IHRlc3RlZD8gSSBzZWUgeW91IGhhdmUgY2xvY2sgdmFsdWVz IHVwIHRvIDI5N01IeiwKPiBzbyA0a0AzMEh6PwoKVGhlIGhpZ2hlc3QgcmVzb2x1dGlvbiBJJ3Zl IHBlcnNvbmFsbHkgdGVzdGVkIGlzIDE0NDB4OTAwLiBJJ2QgbmVlZCB0byBidXkgCmFub3RoZXIg bW9uaXRvciB0byBnbyBoaWdoZXIgdGhhbiB0aGF0LCBidXQgbWF5YmUgdGhpcyBpcyB0aGUgZXhj dXNlIEkndmUgYmVlbiAKd2FpdGluZyBmb3IgOi0pCgo+IElmIEkgc2VuZCBhIHBhdGNoIHdpdGgg YSBnZW5lcmFsIGNvbmZpZyBmdW5jdGlvbiBmb3IgSERNSSAyLjAgcGh5cyBjYW4geW91Cj4gdGVz dCBpdCBvbiB5b3VyIHBsYXRmb3JtPwoKU3VyZSwgSSdkIGJlIGdsYWQgdG8uCgotLSAKUmVnYXJk cywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751922AbdFVO1r (ORCPT ); Thu, 22 Jun 2017 10:27:47 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:59017 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812AbdFVO1q (ORCPT ); Thu, 22 Jun 2017 10:27:46 -0400 From: Laurent Pinchart To: Jose Abreu Cc: Mark Yao , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Kieran Bingham , Laurent Pinchart , Archit Taneja , Andrzej Hajda , Carlos Palminha Subject: Re: [PATCH] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY Date: Thu, 22 Jun 2017 17:28:21 +0300 Message-ID: <2032791.zG0HDMl4PB@avalon> User-Agent: KMail/4.14.10 (Linux/4.9.16-gentoo; KDE/4.14.32; x86_64; ; ) In-Reply-To: <1941ce39-1a8e-5e16-bdc2-71d988ee00d6@synopsys.com> References: <3690108.zYIGBGnVBz@avalon> <1941ce39-1a8e-5e16-bdc2-71d988ee00d6@synopsys.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jose, On Tuesday 13 Jun 2017 15:11:27 Jose Abreu wrote: > Hi Laurent, > > Sorry for the late reply! No worries. > On 10-06-2017 09:50, Laurent Pinchart wrote: > > On Friday 09 Jun 2017 13:53:12 Jose Abreu wrote: > >> On 09-06-2017 12:04, Jose Abreu wrote: > >>> Currently HDMI 2.0 PHYs do not have a default configuration function. > >>> > >>> As these PHYs have the same register layout as the 3D PHYs we can > >>> safely use the default configuration function. > >> > >> I may have been a little to fast arriving at this conclusion. I > >> mean most of the registers match but in the configuration > >> function there are registers that do not match. Did you actually > >> test this configuration function with an HDMI 2.0 phy? And did > >> you test with different video modes? From my experience the phy > >> may be wrongly configured and sometimes work anyway. > >> > >> Do please retest with as many video modes as you can and give me > >> your phy ID (read from controller config reg HDMI_CONFIG2_ID). > > > > The Renesas R-Car Gen3 HDMI PHY reports an DWC HDMI 2.0 TX PHY ID, but has > > a configuration function (rcar_hdmi_phy_configure() in > > drivers/gpu/drm/rcar- du/rcar_dw_hdmi.c) that doesn't match > > hdmi_phy_configure_dwc_hdmi_3d_tx(). From the information I have been > > given the layout of the configuration registers haven't been changed by > > Renesas. I know we've briefly discussed this in the past, but I'd > > appreciate if you could have a second look and tell me what you think. > > Yup, yours seems correct. Though at the time you submitted I > found it odd that only 3 registers needed to be written whilst > for HDMI 2.0 phys I have here 6 registers, but you said it is > working so I though your phy was different ... > > Even so, one thing I would like to know is what was the max > resolution you tested? I see you have clock values up to 297MHz, > so 4k@30Hz? The highest resolution I've personally tested is 1440x900. I'd need to buy another monitor to go higher than that, but maybe this is the excuse I've been waiting for :-) > If I send a patch with a general config function for HDMI 2.0 phys can you > test it on your platform? Sure, I'd be glad to. -- Regards, Laurent Pinchart