From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm/rcar-du: Add missing dependency on CMA Date: Wed, 10 Jul 2013 13:35:31 +0200 Message-ID: <2033202.g329uvd6Un@avalon> References: <1373453534-6425-1-git-send-email-broonie@kernel.org> <9815009.SJ9cp8Rvrj@avalon> <20130710110724.GD24508@sirena.org.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0060287668==" Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [95.142.166.194]) by gabe.freedesktop.org (Postfix) with ESMTP id A549FE5C3C for ; Wed, 10 Jul 2013 04:34:55 -0700 (PDT) In-Reply-To: <20130710110724.GD24508@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Mark Brown , David Airlie Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0060287668== Content-Type: multipart/signed; boundary="nextPart1695661.PfM779QrGS"; micalg="pgp-sha1"; protocol="application/pgp-signature" --nextPart1695661.PfM779QrGS Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Wednesday 10 July 2013 12:07:24 Mark Brown wrote: > On Wed, Jul 10, 2013 at 12:54:40PM +0200, Laurent Pinchart wrote: > > On Wednesday 10 July 2013 11:52:14 Mark Brown wrote: > > > config DRM_RCAR_DU > > > > > > tristate "DRM Support for R-Car Display Unit" > > > > > > - depends on DRM && ARM > > > + depends on DRM && ARM && CMA > > > > > > select DRM_KMS_HELPER > > > select DRM_KMS_CMA_HELPER > > > select DRM_GEM_CMA_HELPER > > > > Shouldn't we instead make DRM_GEM_CMA_HELPER depend on CMA ? > > Sadly select doesn't do the right thing with dependencies - it just ignores > them. OK, my bad. On the other hand, thinking a bit more about this, the DU driver doesn't use the CMA API directly, as there's no CMA API exposed to drivers :-) I've successfully built the driver with CONFIG_CMA disabled. Could you please share the .config that resulted in a link error ? -- Regards, Laurent Pinchart --nextPart1695661.PfM779QrGS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQEcBAABAgAGBQJR3UcDAAoJEIkPb2GL7hl1yS4IAIKX+MzF38byn6cT+aofi2CS aaIEirLmNDYEzpeqkKUMQuyd7o0VDMSA7teqc5B+T7SgNfw4xVpwtPZ533o2Ro4S BnGzJrIi4k/PAls0oT5NfyHQGpFi8OdqHuBLc4/rwlkkyTPYoTxmlvJEnFYsrROF H4R9EZ+Wgv80KRvMXegLVx9Soo5DFJjLwF1Q1HnSnCGfBJQf4AzFAOVEpsoILUjG qx9Up+dhP9cqjagGBVb//QC5c26JOI/ksODS0J2+zA+SSmTPtjJoNFpC0xkTPJf3 fNcYsMXkhgzVlIGyIt6H6Ec7ymiEBxpfKMMGOk8QWfFTheGtPbLfD935s8Xszr4= =uxDi -----END PGP SIGNATURE----- --nextPart1695661.PfM779QrGS-- --===============0060287668== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0060287668==--