All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stephan Müller" <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Eric Biggers <ebiggers3@gmail.com>,
	syzbot
	<bot+3401d9494b9380f7244bcc7fec49680878fccba6@syzkaller.appspotmail.com>,
	davem@davemloft.net, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH v2] crypto: AF_ALG - race-free access of encryption flag
Date: Wed, 29 Nov 2017 12:05:13 +0100	[thread overview]
Message-ID: <2034920.efhAd224kL@positron.chronox.de> (raw)
In-Reply-To: <20171129071049.GA23023@gondor.apana.org.au>

Am Mittwoch, 29. November 2017, 08:10:49 CET schrieb Herbert Xu:

Hi Herbert,

> 
> It sort of worked for skcipher because it didn't care if ctx->enc
> or even ctx->iv changed midstream.  But even there I don't think
> we need to wait a second time.  In fact waiting a second time could
> result in a dead-lock if no sendmsg call came around.

Shouldn't we then create a patch for the pre-4.14 algif_skcipher code that 
moves the wait out of the while loop to the beginning of the function in 
recvmsg?

Ciao
Stephan

  parent reply	other threads:[~2017-11-29 11:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-27 18:56 general protection fault in blkcipher_walk_done syzbot
2017-11-28  5:37 ` Eric Biggers
2017-11-28  7:53   ` Eric Biggers
2017-11-28  8:31     ` Stephan Mueller
2017-11-28  9:03   ` Stephan Mueller
2017-11-28 21:33     ` [PATCH v2] crypto: AF_ALG - race-free access of encryption flag Stephan Müller
2017-11-28 22:40       ` Eric Biggers
2017-11-28 23:02       ` Herbert Xu
2017-11-29  6:48         ` Stephan Mueller
2017-11-29  7:10           ` Herbert Xu
2017-11-29  7:17             ` Stephan Mueller
2017-11-29 10:17               ` [PATCH] crypto: AF_ALG - wait for data at beginning of recvmsg Stephan Müller
2017-11-29 10:22                 ` Herbert Xu
2017-11-29 10:28                   ` Stephan Mueller
2017-11-29 10:42                     ` Herbert Xu
2017-11-29 11:02                       ` [PATCH v2] " Stephan Müller
2017-12-11 11:45                         ` Herbert Xu
2017-11-29 11:05             ` Stephan Müller [this message]
2017-11-29 12:17               ` [PATCH v2] crypto: AF_ALG - race-free access of encryption flag Herbert Xu
2017-12-11 19:10 ` general protection fault in blkcipher_walk_done Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2034920.efhAd224kL@positron.chronox.de \
    --to=smueller@chronox.de \
    --cc=bot+3401d9494b9380f7244bcc7fec49680878fccba6@syzkaller.appspotmail.com \
    --cc=davem@davemloft.net \
    --cc=ebiggers3@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.