From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752991AbaDDNTQ (ORCPT ); Fri, 4 Apr 2014 09:19:16 -0400 Received: from mail.efficios.com ([78.47.125.74]:33790 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752658AbaDDNTO convert rfc822-to-8bit (ORCPT ); Fri, 4 Apr 2014 09:19:14 -0400 Date: Fri, 4 Apr 2014 13:19:10 +0000 (UTC) From: Mathieu Desnoyers To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Frederic Weisbecker , Andrew Morton , "Frank Ch. Eigler" , Johannes Berg Message-ID: <20367690.6153.1396617550266.JavaMail.zimbra@efficios.com> In-Reply-To: <1275825820.6059.1396582817493.JavaMail.zimbra@efficios.com> References: <1396391508-17294-1-git-send-email-mathieu.desnoyers@efficios.com> <1396391508-17294-2-git-send-email-mathieu.desnoyers@efficios.com> <20140403131559.4ed4cf5e@gandalf.local.home> <693620685.5916.1396547394009.JavaMail.zimbra@efficios.com> <20140403145441.2ca44063@gandalf.local.home> <1275825820.6059.1396582817493.JavaMail.zimbra@efficios.com> Subject: Re: [PATCH v9 1/1] Tracepoint: register/unregister struct tracepoint MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [206.248.138.119] X-Mailer: Zimbra 8.0.5_GA_5839 (ZimbraWebClient - FF28 (Linux)/8.0.5_GA_5839) Thread-Topic: Tracepoint: register/unregister struct tracepoint Thread-Index: lDWcRFrlJOXKJY02xngFA1W8YXr6csnLYkxX Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Original Message ----- > From: "Mathieu Desnoyers" > To: "Steven Rostedt" > Cc: linux-kernel@vger.kernel.org, "Ingo Molnar" , "Frederic Weisbecker" , > "Andrew Morton" , "Frank Ch. Eigler" , "Johannes Berg" > > Sent: Thursday, April 3, 2014 11:40:17 PM > Subject: Re: [PATCH v9 1/1] Tracepoint: register/unregister struct tracepoint > > ----- Original Message ----- > > From: "Steven Rostedt" > > To: "Mathieu Desnoyers" > > Cc: linux-kernel@vger.kernel.org, "Ingo Molnar" , > > "Frederic Weisbecker" , > > "Andrew Morton" , "Frank Ch. Eigler" > > , "Johannes Berg" > > > > Sent: Thursday, April 3, 2014 2:54:41 PM > > Subject: Re: [PATCH v9 1/1] Tracepoint: register/unregister struct > > tracepoint > > > > On Thu, 3 Apr 2014 17:49:54 +0000 (UTC) > > Mathieu Desnoyers wrote: > > > > > > > So my current thinking is that the pre-existing code was erroneously > > > enabling tracepoints with the name of every event enabled (including > > > e.g. function tracer, kprobes, etc). It was not failing because > > > tracepoint.c silently accepted to enable tracepoints were not loaded > > > yet. > > > > > > > If that was true, than wouldn't the error code I added have returned an > > error? > > Good point. > > I found the culprit: > > [ 0.560002] event_trace_enable: �GT����� call ffffffff81613930 (core) > [ 0.564001] event_trace_enable: �GTȁ���� call ffffffff816139c0 (core) > > compudj@ok:~/git/rostedt/linux-trace$ objdump -t vmlinux |grep > ffffffff81613930 > ffffffff81613930 l O .data 0000000000000090 event_sys_exit > compudj@ok:~/git/rostedt/linux-trace$ objdump -t vmlinux |grep > ffffffff816139c0 > ffffffff816139c0 l O .data 0000000000000090 event_sys_enter > > I'll look into those two sites tomorrow morning. And here is the fix: diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h index 7538389..75e64e8 100644 --- a/include/linux/ftrace_event.h +++ b/include/linux/ftrace_event.h @@ -371,7 +371,7 @@ struct ftrace_event_file { #define __TRACE_EVENT_FLAGS(name, value) \ static int __init trace_init_flags_##name(void) \ { \ - event_##name.flags = value; \ + event_##name.flags |= value; \ return 0; \ } \ early_initcall(trace_init_flags_##name); I will respin a new version after some extra testing. Thanks! Mathieu > > Thanks, > > Mathieu > > > > > -- Steve > > > > -- > Mathieu Desnoyers > EfficiOS Inc. > http://www.efficios.com > -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com