Re: [RFC 1/3] ethdev: support GRE optional fields

[Thomas Monjalon <thomas@monjalon.net>]

19/01/2022 10:53, Ferruh Yigit:
> On 12/30/2021 3:08 AM, Sean Zhang wrote:
> > --- a/lib/ethdev/rte_flow.h
> > +++ b/lib/ethdev/rte_flow.h
> >   /**
> > + * RTE_FLOW_ITEM_TYPE_GRE_OPTION.
> > + *
> > + * Matches GRE optional fields in header.
> > + */
> > +struct rte_gre_hdr_option {
> > +	rte_be16_t checksum;
> > +	rte_be32_t key;
> > +	rte_be32_t sequence;
> > +};
> > +
> 
> Hi Ori, Andrew,
> 
> The decision was to have protocol structs in the net library and flow structs
> use from there, wasn't it?
> (Btw, a deprecation notice is still pending to clear some existing ones)
> 
> So for the GRE optional fields, what about having a struct in the 'rte_gre.h'?
> (Also perhaps an GRE extended protocol header can be defined combining
> 'rte_gre_hdr' and optional fields struct.)
> Later flow API struct can embed that struct.

+1 for using librte_net.
This addition in rte_flow looks to be a mistake.
Please fix in the next version.