From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from goalie.tycho.ncsc.mil (goalie [144.51.242.250]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u38Ja60r009980 for ; Fri, 8 Apr 2016 15:36:07 -0400 Received: by mail-qg0-f67.google.com with SMTP id b32so10905212qgf.2 for ; Fri, 08 Apr 2016 12:36:04 -0700 (PDT) From: Paul Moore To: Paolo Abeni Cc: linux-security-module@vger.kernel.org, James Morris , "Serge E. Hallyn" , Kees Cook , Casey Schaufler , linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov Subject: Re: [PATCH net-next] security: drop the unused hook skb_owned_by Date: Fri, 08 Apr 2016 15:36:02 -0400 Message-ID: <2038247.4BhNsDBffi@sifl> In-Reply-To: <25cbac8df32da8527bac7187f606e6351862702d.1460110723.git.pabeni@redhat.com> References: <25cbac8df32da8527bac7187f606e6351862702d.1460110723.git.pabeni@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: On Friday, April 08, 2016 12:20:30 PM Paolo Abeni wrote: > The skb_owned_by hook was added with the commit ca10b9e9a8ca > ("selinux: add a skb_owned_by() hook") and later removed > when said commit was reverted. > > Later on, when switching to list of hooks, a field named > 'skb_owned_by' was included into the security_hook_head struct, > but without any users nor caller. > > This commit removes the said left-over field. > > Fixes: b1d9e6b0646d ("LSM: Switch to lists of hooks") > Signed-off-by: Paolo Abeni > --- > include/linux/lsm_hooks.h | 1 - > security/security.c | 1 - > 2 files changed, 2 deletions(-) No objections here. Acked-by: Paul Moore > diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h > index cdee11c..ae25378 100644 > --- a/include/linux/lsm_hooks.h > +++ b/include/linux/lsm_hooks.h > @@ -1804,7 +1804,6 @@ struct security_hook_heads { > struct list_head tun_dev_attach_queue; > struct list_head tun_dev_attach; > struct list_head tun_dev_open; > - struct list_head skb_owned_by; > #endif /* CONFIG_SECURITY_NETWORK */ > #ifdef CONFIG_SECURITY_NETWORK_XFRM > struct list_head xfrm_policy_alloc_security; > diff --git a/security/security.c b/security/security.c > index 3644b03..554c3fb 100644 > --- a/security/security.c > +++ b/security/security.c > @@ -1848,7 +1848,6 @@ struct security_hook_heads security_hook_heads = { > .tun_dev_attach = > LIST_HEAD_INIT(security_hook_heads.tun_dev_attach), > .tun_dev_open = LIST_HEAD_INIT(security_hook_heads.tun_dev_open), > - .skb_owned_by = LIST_HEAD_INIT(security_hook_heads.skb_owned_by), > #endif /* CONFIG_SECURITY_NETWORK */ > #ifdef CONFIG_SECURITY_NETWORK_XFRM > .xfrm_policy_alloc_security = -- paul moore www.paul-moore.com