From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>,
dev@dpdk.org, anatoly.burakov@intel.com,
david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] eal: fix argument to rte_bsf32_safe
Date: Tue, 20 Jul 2021 15:26:26 +0200 [thread overview]
Message-ID: <2043133.xR68YOe5AU@thomas> (raw)
In-Reply-To: <20210719150022.249fe1a9@hermes.local>
20/07/2021 00:00, Stephen Hemminger:
> On Mon, 19 Jul 2021 10:15:34 -0700
> Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
>
> > On Tue, Jul 13, 2021 at 01:12:21PM -0700, Stephen Hemminger wrote:
> > > The first argument to rte_bsf32_safe was incorrectly declared as
> > > a 64 bit value. This function only correctly handles on 32 bit values
> > > and the underlying function rte_bsf32 only accepts 32 bit values.
> > > This was introduced when the safe version was added and probably cause
> > > by copy/paste from the 64 bit version.
> >
> > there are multiple errors in this family of functions [1] both in usage
> > and signatures. we previously discussed rolling all fixes up into a single
> > patch and announcing an api break.
> >
> > a doc patch was submitted as per the process documented for breaking api
> > but received no replies [2]
> >
> > i have a full patch that corrects the whole family if you would like to
> > take it instead. contact me offline if you are interested.
> >
> > 1. http://mails.dpdk.org/archives/dev/2021-March/201590.html
> > 2. http://mails.dpdk.org/archives/dev/2021-March/201868.html
> >
> > the change stand-alone is correct so
> >
> > Acked-By: Tyler Retzlaff <roretzla@linux.microsoft.com>
>
> Thanks, I think the larger set should go into 21.11 where API/ABI break
> would be ok. My bit was all about fixing the bug where current code
> breaks C++ users.
Shouldn't we have a note in the API changes section of the release notes?
next prev parent reply other threads:[~2021-07-20 13:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 20:12 [dpdk-dev] [PATCH] eal: fix argument to rte_bsf32_safe Stephen Hemminger
2021-07-19 17:15 ` Tyler Retzlaff
2021-07-19 22:00 ` Stephen Hemminger
2021-07-20 13:26 ` Thomas Monjalon [this message]
2021-07-23 0:52 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2021-07-23 15:45 ` [dpdk-dev] [PATCH v3] " Stephen Hemminger
2021-07-24 7:58 ` Thomas Monjalon
2021-07-24 23:50 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2043133.xR68YOe5AU@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.