All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Demote i915_gem_open() debugging from DRIVER to USER
Date: Thu, 17 Nov 2016 14:13:36 +0000	[thread overview]
Message-ID: <20448938-82e2-eec4-c74e-b25fd9b35582@linux.intel.com> (raw)
In-Reply-To: <20161109104507.21228-1-chris@chris-wilson.co.uk>


On 09/11/2016 10:45, Chris Wilson wrote:
> We use DRM_DEBUG() when reporting on user actions, to try and keep
> intentional errors out of the CI dmesg. Demote the debug from
> i915_gem_open() similarly so that it is only apparent with drm.debug & 1
> like its brethren.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/i915_gem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 2450c99d29ae..951d392427d8 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -5054,7 +5054,7 @@ int i915_gem_open(struct drm_device *dev, struct drm_file *file)
>  	struct drm_i915_file_private *file_priv;
>  	int ret;
>
> -	DRM_DEBUG_DRIVER("\n");
> +	DRM_DEBUG("\n");
>
>  	file_priv = kzalloc(sizeof(*file_priv), GFP_KERNEL);
>  	if (!file_priv)
>

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-11-17 14:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-09 10:45 [PATCH] drm/i915: Demote i915_gem_open() debugging from DRIVER to USER Chris Wilson
2016-11-09 12:15 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-11-17 14:13 ` Tvrtko Ursulin [this message]
2016-11-17 14:29   ` [PATCH] " Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20448938-82e2-eec4-c74e-b25fd9b35582@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.