From: Thomas Monjalon <thomas@monjalon.net>
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: dev@dpdk.org, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com,
navasile@linux.microsoft.com, dmitrym@microsoft.com,
david.marchand@redhat.com, anatoly.burakov@intel.com,
vladimir.medvedkin@intel.com, mb@smartsharesystems.com
Subject: Re: [dpdk-dev] [PATCH v4 2/2] eal: rename key opaque pointer and functions in TLS API
Date: Tue, 16 Mar 2021 00:16:06 +0100 [thread overview]
Message-ID: <20454891.HEvSqZ4d6T@thomas> (raw)
In-Reply-To: <20210310124856.8188-3-talshn@nvidia.com>
10/03/2021 13:48, Tal Shnaiderman:
> rename the key opaque pointer from rte_tls_key to
> rte_thread_key to avoid confusion with transport layer security.
>
> Also rename and remove the "_tls" term from the following
> functions to avoid redundancy:
>
> rte_thread_tls_key_create
> rte_thread_tls_key_delete
> rte_thread_tls_value_set
> rte_thread_tls_value_get
>
> Suggested-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> Suggested-by: Morten Brørup <mb@smartsharesystems.com>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> ---
> drivers/net/mlx5/linux/mlx5_flow_os.c | 10 +++++-----
> drivers/net/mlx5/windows/mlx5_flow_os.c | 12 ++++++------
> lib/librte_eal/include/rte_thread.h | 19 ++++++++++---------
> lib/librte_eal/rte_eal_exports.def | 8 ++++----
> lib/librte_eal/unix/rte_thread.c | 8 ++++----
> lib/librte_eal/version.map | 8 ++++----
> lib/librte_eal/windows/rte_thread.c | 8 ++++----
> 7 files changed, 37 insertions(+), 36 deletions(-)
Updating an API, even experimental, requires an entry in the release notes.
next prev parent reply other threads:[~2021-03-15 23:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 15:26 [dpdk-dev] [PATCH v2 0/2] EAL Thread TLS API enhancements Tal Shnaiderman
2021-03-02 15:26 ` [dpdk-dev] [PATCH v2 1/2] eal: error number enhancement for thread TLS API Tal Shnaiderman
2021-03-02 17:09 ` Dmitry Kozlyuk
2021-03-03 10:37 ` Tal Shnaiderman
2021-03-03 11:10 ` Dmitry Kozlyuk
2021-03-03 11:53 ` Tal Shnaiderman
2021-03-10 12:06 ` [dpdk-dev] [PATCH v3 0/2] EAL Thread TLS API enhancements Tal Shnaiderman
2021-03-10 12:06 ` [dpdk-dev] [PATCH v3 1/2] eal: error number enhancement for thread TLS API Tal Shnaiderman
2021-03-10 12:48 ` [dpdk-dev] [PATCH v4 0/2] EAL Thread TLS API enhancements Tal Shnaiderman
2021-03-10 12:48 ` [dpdk-dev] [PATCH v4 1/2] eal: error number enhancement for thread TLS API Tal Shnaiderman
2021-03-10 19:45 ` Narcisa Ana Maria Vasile
2021-03-15 15:37 ` Tal Shnaiderman
2021-03-13 2:29 ` Dmitry Kozlyuk
2021-03-15 23:14 ` Thomas Monjalon
2021-03-16 9:15 ` [dpdk-dev] [PATCH v5 0/2] EAL Thread TLS API enhancements Tal Shnaiderman
2021-03-16 9:15 ` [dpdk-dev] [PATCH v5 1/2] eal: error number enhancement for thread TLS API Tal Shnaiderman
2021-03-16 13:28 ` [dpdk-dev] [PATCH v6 0/2] EAL Thread TLS API enhancements Tal Shnaiderman
2021-03-16 13:28 ` [dpdk-dev] [PATCH v6 1/2] eal: error number enhancement for thread TLS API Tal Shnaiderman
2021-03-16 13:28 ` [dpdk-dev] [PATCH v6 2/2] eal: rename key opaque pointer and functions in " Tal Shnaiderman
2021-03-26 8:24 ` [dpdk-dev] [PATCH v6 0/2] EAL Thread TLS API enhancements Thomas Monjalon
2021-03-16 9:15 ` [dpdk-dev] [PATCH v5 2/2] eal: rename key opaque pointer and functions in TLS API Tal Shnaiderman
2021-03-10 12:48 ` [dpdk-dev] [PATCH v4 " Tal Shnaiderman
2021-03-15 23:16 ` Thomas Monjalon [this message]
2021-03-16 9:17 ` Tal Shnaiderman
2021-03-10 12:06 ` [dpdk-dev] [PATCH v3 " Tal Shnaiderman
2021-03-10 12:22 ` Morten Brørup
2021-03-02 15:26 ` [dpdk-dev] [PATCH v2 2/2] eal: rename key opaque pointer " Tal Shnaiderman
2021-03-02 15:36 ` Morten Brørup
2021-03-04 11:16 ` Tal Shnaiderman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20454891.HEvSqZ4d6T@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=mb@smartsharesystems.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=talshn@nvidia.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.