All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map
Date: Thu, 25 Feb 2021 12:41:16 +0100	[thread overview]
Message-ID: <2047120.oh6f1MFQjV@thomas> (raw)
In-Reply-To: <20210225111457.32540-1-david.marchand@redhat.com>

25/02/2021 12:14, David Marchand:
> Add a check on versioned symbol duplicates in map files.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> This check could be added to buildtools/check-symbols.sh so that
> regular developers catch the issue when building their changes...
> Opinions?

In general I am against adding developer tools in the build process,
because it could cause more issues for normal users.




  reply	other threads:[~2021-02-25 11:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 11:14 [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map David Marchand
2021-02-25 11:41 ` Thomas Monjalon [this message]
2021-02-25 11:57   ` Bruce Richardson
2021-02-25 12:01     ` Thomas Monjalon
2021-02-25 12:05       ` Bruce Richardson
2021-02-25 13:14         ` Thomas Monjalon
2021-05-05 14:30 ` [dpdk-dev] [PATCH v2 1/2] " David Marchand
2021-05-05 14:30   ` [dpdk-dev] [PATCH v2 2/2] buildtools: check symbol maps in developer mode David Marchand
2021-05-06  9:31     ` Kinsella, Ray
2021-05-12 20:24       ` Thomas Monjalon
2021-05-12 20:38         ` Thomas Monjalon
2021-05-13  7:06           ` David Marchand
2021-05-13  8:34 ` [dpdk-dev] [PATCH v3 1/3] devtools: fix orphan symbols check with busybox David Marchand
2021-05-13  8:34   ` [dpdk-dev] [PATCH v3 2/3] devtools: catch symbol duplicates in version map David Marchand
2021-05-13  8:34   ` [dpdk-dev] [PATCH v3 3/3] build: check symbol maps in developer mode David Marchand
2021-05-19 10:52     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2047120.oh6f1MFQjV@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.